Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] make bounding box an attribute of the project #13

Open
lachlangrose opened this issue Jan 23, 2024 · 1 comment
Open

[feature] make bounding box an attribute of the project #13

lachlangrose opened this issue Jan 23, 2024 · 1 comment
Assignees
Labels
low priority we will do it ... eventually

Comments

@lachlangrose
Copy link
Member

Bounding box is used by mapdata to crop the datasets, would be good if the bounding box could be changed without requiring a new project to be built.

proj.map_data.set_bounding_box(bounding_box)
proj.map_data.load_all_map_data()

@RoyThomsonMonash if the bounding box changes and mapdata is updated, it does not seem to update the region of interest. Do the shapefiles get loaded and then cropped or is a copy stored on the object so we could change the bounding box?

I think for the proj it would be good to have a @property for bounding box and trigger any updates when the object is set.

@RoyThomsonMonash
Copy link
Contributor

The raw map data is stored before it is clipped so in theory you could set the dirtyflags on all maps to True:
proj.map_data.dirtyflags = [True] * len(Datatype)
and then set the datastate to LOADED:
proj.map_data.data_states = [Datastate.LOADED] * len(Datatype)
but this is untested as a change in the bounding box during runtime was not anticipated.

@AngRodrigues AngRodrigues added high priority on top of our to do low priority we will do it ... eventually and removed high priority on top of our to do labels May 23, 2024
@AngRodrigues AngRodrigues self-assigned this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority we will do it ... eventually
Projects
None yet
Development

No branches or pull requests

3 participants