Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property and inheritance #669

Open
camlafit opened this issue Aug 27, 2021 · 4 comments
Open

Property and inheritance #669

camlafit opened this issue Aug 27, 2021 · 4 comments

Comments

@camlafit
Copy link
Contributor

Hello

When we declare an object has return, inheritance is not take in consideration.
For example to
@return MyValueObject $myobject Description

and

/**
 *@property string $parentobject
 */
Class ParentMyValueObject extends \Luracast\Restler\Data\ValueObject {
    $public $parentobject;
    ...
}

Class MyValueObject extends ParentMyValueObject {
     ...
}

In Model description provide by API Explorer , $parentobject property is missing.

Thanks

@camlafit
Copy link
Contributor Author

@camlafit
Copy link
Contributor Author

camlafit commented Aug 30, 2021

To use subType, I think model structure should be reviewed and to allow others elements than children.
As list() are used then to retrieve others contents as subType is not easy .

@Arul-
Copy link
Member

Arul- commented Sep 1, 2021

Actually inherited properties work just fine. I have added a test in a4871d3 to make sure!

@camlafit
Copy link
Contributor Author

camlafit commented Sep 1, 2021

Hello

When we use @property and settter/getter behavior is different. I prepare a sample code to be more explicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants