Changed behaviour when the 2x variants are used in V6.x ?

[Gendra13]

Lychee version

V6.0.1

Which PHP version are you using?

PHP 8.3

Detailed description of the problem

I'm not sure, if this is really a bug or just a change in bevahoiur between the old and new version:

I'am using Lychee on an (high-DPI) 4k screen.
When I open an album with the old version (5.x), then it would automatically select the small2x variants to generate the album view.
After updating to version 6.0.1 it now only displays the small variants which look rather dull and blurry in comparsion.
However, when I enlarge the image, then it correcly selects the medium2x variant in both version.

Has there been a change which size variants are used in the album view? Is there a way to make Lychee use the 2x variants again?

Old version (5.3.0)

New Version (6.0.1):

Steps to reproduce the issue

1. Open an album on a high-resultion screen with the old an new version
2. Check in the browser console which images are fetched
3. For the old versions it will generate the view with the small2x variants while the new version will only use the small variants.

Diagnostics [REQUIRED]

Errors
warning
/v**********************lic/sym/ has permissions 0755, but should have 2775
warning
/var/*****************torage/tmp/jobs/ has permissions 0755, but should have 2775
warning
/var/*****************torage/tmp/uploads/ has permissions 0755, but should have 2775
warning
Default timezone not properly set; you might experience strange results when importing photos without explicit EXIF timezone

Lychee Version (release):                  6.0.1
DB Version:                                6.0.1
composer install:                          --no-dev
APP_ENV:                                   production
APP_DEBUG:                                 false
APP_URL:                                   set
APP_DIR:                                   set
LOG_VIEWER_ENABLED:                        true
VUEJS_ENABLED:                             true
PHOTO_PIPES:                               true
System:                                    Linux
PHP Version:                               8.3.12
PHP User agent:                            Lychee/4 (https://lycheeorg.github.io/)
Timezone:                                  UTC
Max uploaded file size:                    512M
Max post size:                             512M
Chunk size:                                12.80 MB
Max execution time:                        300
MySQL Version:                             10.6.18-MariaDB-0ubuntu0.22.04.1
exec() Available:                          yes
Imagick Available:                         1
Imagick Enabled:                           1
Imagick Version:                           1691
GD Version:                                2.3.3
Number of foreign key:                     24 found.

		

Space
Configuration

version:                                   060001
check_for_updates:                         1
sorting_photos_col:                        taken_at
sorting_photos_order:                      ASC
sorting_albums_col:                        max_taken_at
sorting_albums_order:                      ASC
imagick:                                   1
skip_duplicates:                           1
small_max_width:                           0
small_max_height:                          360
medium_max_width:                          1920
medium_max_height:                         1080
lang:                                      en
image_overlay_type:                        none
default_license:                           reserved
compression_quality:                       90
grants_full_photo_access:                  1
delete_imported:                           0
mod_frame_enabled:                         0
mod_frame_refresh:                         30
thumb_2x:                                  1
small_2x:                                  1
medium_2x:                                 1
landing_page_enable:                       0
force_migration_in_production:             0
search_public:                             0
hide_version_number:                       0
SL_enable:                                 0
SL_for_admin:                              0
recent_age:                                1
grants_download:                           0
photos_wraparound:                         1
map_display:                               1
zip64:                                     1
map_display_public:                        1
map_provider:                              OpenStreetMap.de
force_32bit_ids:                           0
map_include_subalbums:                     1
update_check_every_days:                   3
has_exiftool:                              0
share_button_visible:                      0
import_via_symlink:                        0
has_ffmpeg:                                0
location_decoding:                         1
location_decoding_timeout:                 30
location_show:                             1
location_show_public:                      1
rss_enable:                                0
rss_recent_days:                           7
rss_max_items:                             100
prefer_available_xmp_metadata:             0
editor_enabled:                            1
lossless_optimization:                     0
swipe_tolerance_x:                         150
swipe_tolerance_y:                         250
local_takestamp_video_formats:             .avi|.mov
log_max_num_line:                          1000
unlock_password_photos_with_url_param:     0
nsfw_visible:                              1
nsfw_blur:                                 0
nsfw_warning:                              0
nsfw_warning_admin:                        0
nsfw_banner_override:                      
map_display_direction:                     1
album_subtitle_type:                       takedate
upload_processing_limit:                   4
new_photos_notification:                   0
legacy_id_redirection:                     1
zip_deflate_level:                         6
default_album_protection:                  1
album_decoration:                          none
album_decoration_orientation:              row
allow_username_change:                     1
auto_fix_orientation:                      1
use_job_queues:                            1
random_album_id:                           starred
use_last_modified_date_when_no_exif_date:  0
layout:                                    justified
date_format_photo_thumb:                   D, d M Y H:i:s
date_format_photo_overlay:                 D, d M Y H:i:s
date_format_sidebar_uploaded:              D, d M Y H:i:s
date_format_sidebar_taken_at:              D, d M Y H:i:s
date_format_hero_min_max:                  F Y
date_format_hero_created_at:               M Y
date_format_album_thumb:                   M Y
upload_chunk_size:                         0
nsfw_banner_blur_backdrop:                 0
search_pagination_limit:                   1000
search_minimum_length_required:            4
photo_layout_justified_row_height:         320
photo_layout_masonry_column_width:         400
photo_layout_grid_column_width:            250
photo_layout_square_column_width:          180
photo_layout_gap:                          10
display_thumb_album_overlay:               always
display_thumb_photo_overlay:               hover
default_album_thumb_aspect_ratio:          1/1
use_album_compact_header:                  0
login_button_position:                     left
back_button_enabled:                       0
back_button_text:                          Return to Home
current_job_processing_visible:            0
SA_random_thumbs:                          0
job_processing_queue_visible:              1
login_required:                            0
enable_unsorted:                           0
enable_starred:                            0
enable_recent:                             0
enable_on_this_day:                        0
login_required_root_only:                  1
dark_mode_enabled:                         1
show_keybinding_help_popup:                0
show_keybinding_help_button:               1
disable_se_call_for_actions:               0
enable_se_preview:                         1
slideshow_timeout:                         5
keep_original_untouched:                   1
hide_nsfw_in_smart_albums_and_search:      1

		

Browser & System [REQUIRED]

Server:
Ubuntu 22.05 LTS php8.3.12

Client:
Windows 10
Firefox 132.0
Asus PG32UQ screen (32" 3840x2160)

Please confirm (incomplete submissions will not be addressed)

• I have provided easy and step-by-step instructions to reproduce the bug.
• I understand my bug report will be removed if I haven't met the criteria above.

[ildyria]

I will try to have a look on the src-set side, it might be that the string for selecting the variant is not properly formatted.

[Gendra13]

I tried to find a fix for this, but unfortunately, I wasn't successful.

Could you maybe point me to the place in the code where the image variant is choosen? Then I can try changing the behavior.

[Gendra13]

@ildyria
I tried to look a bit further into this and I believe you are right, there seem to be a problem with the src-set value:
Instead of the respective paths to the image-variants it seems to contain only the string [object Object] for all images.

I tried poking around here, where I suspect the srcset is set, however with my little knowledge of web-apps this was not successful.
Maybe you have another idea?

[ildyria]

Well that explains a lot!

[ildyria]

#2687 Fix.

[Gendra13]

Thanks.