Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrectly accepts form-feed #8

Open
d0sboots opened this issue Sep 14, 2022 · 2 comments
Open

Incorrectly accepts form-feed #8

d0sboots opened this issue Sep 14, 2022 · 2 comments

Comments

@d0sboots
Copy link

prv_skip_blank has the following comment:

Skip all characters that are considered *blank* as per RFC4627

However, \f has never been considered a whitespace character in RFC4627.

Also applies to streaming mode.

@MaJerle
Copy link
Owner

MaJerle commented Sep 14, 2022

skip blank character only applies when outside string parsing. Should we treat \f with special attention?

I am not sure I understand where the problem is - you have test JSON that fails?

@d0sboots
Copy link
Author

I am not sure I understand where the problem is - you have test JSON that fails?

Sure. Your library will parse "{\f}" as an empty object, but it's not valid JSON. (Here the \f denotes the form-feed character, i.e. if you used that string literal in C or JS to make the test case, it should fail.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants