Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'done_info' not generated and incorrect reward counting on maximum steps completion #7

Open
xyzeroth opened this issue Nov 20, 2023 · 0 comments

Comments

@xyzeroth
Copy link

It seems that when an actor successfully completes the maximum number of steps (2048) without failure,

any 'done_info' is not generated at Line 214,

and no 'done_info' is appended to 'completed_episode_info' at Line 296.

# If some of the actors finished AND this is not the last step

Consequently, the reward is counted as -1, as observed in the code snippet at Line 324.

If an actor reaches the maximum step without any failures, it should be considered 'done,' and the reward should be counted to the total reward as it is, rather than being set to -1.
Could you please examine how the reward is tallied when an actor successfully completes the maximum number of steps without any failures?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant