-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better handling of binary files #197
Comments
It should be possible to hook into OS or distro open commands if available.
|
This issue should be closed and its details put into #32 and all relevant subcommands. So far this issue is a bit underspecced. Also as per the comment in #44 (comment)
As for what's written in this issue:
This depends on what the For 2., basically all pipes have to deal with binary data. Not just Not sure what you mean by 3. |
This would mostly be handled by the secrets unix style commands. That said, 3 means implementing an edit command that opens an editor related to the file extension. It might not be worth implementing on our side though. |
Specification
While
Polykey
can handle binary files just fine, currently it is very clunky. There are 3 aspects of this.secrets edit
isn't really useful for binary files.secrets get
will output the secret data tostdout
, this usually ends badly for binary files. While we can redirect them to a file withsecrets get > someFile
, we have to manually specify the name of the file with the extension while doing so.secrets open
.I feel that 2 and 3 should be addressed by #32
Additional context
Related #32
Tasks
The text was updated successfully, but these errors were encountered: