Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS to the project #2

Open
MattCrl opened this issue Oct 1, 2018 · 13 comments
Open

Add CSS to the project #2

MattCrl opened this issue Oct 1, 2018 · 13 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@MattCrl
Copy link
Owner

MattCrl commented Oct 1, 2018

You can submit your CSS ideas for this project, everything that is not ugly will be welcome !

@MattCrl MattCrl added enhancement New feature or request good first issue Good for newcomers hacktoberfest labels Oct 1, 2018
@muskan21jain
Copy link

@MattCrl i want to work on this issue. can you guide me to start on

@rahulrana95
Copy link

@MattCrl We need to write a document or something?

@muskan21jain
Copy link

@rahulrana95 i think we need to add css styles on the project by clone the repo to our local computer

@rahulrana95
Copy link

@94151 @MattCrl We can decide on css style guide so it will be better than to write css and have consistent styles

@inyutin
Copy link
Contributor

inyutin commented Oct 1, 2018

Shouldn't we make all pictures added to same size?

@ardgz
Copy link
Contributor

ardgz commented Oct 1, 2018

Shouldn't we make all pictures added to same size?

I agree we should have a standard image size of some sort so the images look consistent. Could do with a CSS rule to set image size as well

@inyutin
Copy link
Contributor

inyutin commented Oct 1, 2018

I will do standard image size now

@inyutin
Copy link
Contributor

inyutin commented Oct 1, 2018

Edit here: #15

@julieg18
Copy link

julieg18 commented Oct 1, 2018

I would like to help on this issue. What project do you want me to add CSS style too?

@inyutin
Copy link
Contributor

inyutin commented Oct 1, 2018

@jujug12 as I edited pictures size there's still a problem that text size might be different. Because of that cards have different size and that look ugly. You may think what to do with that.
For example you can hide text and show it only on hover or something like that

@MattCrl
Copy link
Owner Author

MattCrl commented Oct 1, 2018

I've no specific style in headfor this project. Something sober is fine !
I'll check PR when i have the time, i'm working alone on it so it may take some time if there's alot of PR ;)

@inyutin
Copy link
Contributor

inyutin commented Oct 1, 2018

@MattCrl I'm really interested in this project, so I can help you. E.g. I can check PR with new cards and merge them :)

MattCrl pushed a commit that referenced this issue Oct 2, 2018
@yas-sisodia
Copy link

@MattCrl Please assign this issue to me, I can solve the problem which you are facing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

7 participants