Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-6189: Set all Patient reference fields on test case #462

Merged
merged 4 commits into from
Sep 28, 2023

Conversation

ethankaplan
Copy link
Contributor

MADiE PR

Jira Ticket: MAT-6189
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@ethankaplan ethankaplan requested a review from a team as a code owner September 25, 2023 18:21
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #462 (0eeae5c) into develop (05565ec) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #462   +/-   ##
========================================
  Coverage    94.95%   94.96%           
========================================
  Files           85       85           
  Lines         2756     2759    +3     
  Branches       341      341           
========================================
+ Hits          2617     2620    +3     
  Misses          69       69           
  Partials        70       70           
Files Coverage Δ
...ms/gov/madie/measure/services/TestCaseService.java 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ethankaplan ethankaplan merged commit 4a72c5d into develop Sep 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants