Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update okta dependency version and updates for validation package change #491

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

nmorasb
Copy link
Contributor

@nmorasb nmorasb commented Nov 7, 2023

MADiE PR

Jira Ticket: MAT-6351
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@nmorasb nmorasb requested a review from a team November 7, 2023 19:36
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #491 (954387b) into develop (09ee05c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #491   +/-   ##
========================================
  Coverage    95.36%   95.36%           
========================================
  Files           88       88           
  Lines         2803     2803           
  Branches       347      347           
========================================
  Hits          2673     2673           
  Misses          63       63           
  Partials        67       67           
Files Coverage Δ
...asure/resources/ErrorHandlingControllerAdvice.java 79.54% <ø> (ø)
...easure/validations/ScoringPopulationValidator.java 83.87% <ø> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@nmorasb nmorasb marked this pull request as ready for review November 7, 2023 19:42
@nmorasb nmorasb merged commit 9e1e1da into develop Nov 8, 2023
8 checks passed
@nmorasb nmorasb deleted the feature/MAT-6351-okta-update branch November 8, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants