Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/350 #351

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Feature/350 #351

merged 2 commits into from
Dec 6, 2023

Conversation

afonsobspinto
Copy link
Member

Closes #350

Implemented solution:

  • Awaits for all the children color changes before updating populations
  • Fixes typo

How to test this PR:

  • Change the color of a 'parent' population with many children

Sanity checks:

  • The pull request is explicitly linked to the relevant issue(s)
  • The issue is well described: clearly states the problem and the general proposed solution(s)
  • From the issue and the current PR it is explicitly stated how to test the current change
  • The labels in the issue set the scope and the type of issue (bug, feature, etc.)
  • All the automated test checks are passing
  • All the linked issues are included in one milestone
  • All the linked issues are assigned

Breaking changes (select one):

  • The present changes do not change the preexisting api in any way
  • This PR and the issue are tagged as a breaking-change

Possible deployment updates issues (select one):

  • There is no reason why deployments may break after the current update
  • This PR and the issue are tagged as alert:deployment

Test coverage (select one):

  • Tests for the relevant cases are included in this pr
  • The changes included in this pr are out of the current test coverage scope

Documentation (select one):

  • The documentation has been updated to match the current changes
  • The changes included in this PR are out of the current documentation scope

@afonsobspinto afonsobspinto requested review from D-GopalKrishna and removed request for D-GopalKrishna December 6, 2023 00:07
@afonsobspinto afonsobspinto merged commit 5ea110e into develop Dec 6, 2023
3 checks passed
@afonsobspinto afonsobspinto linked an issue Dec 6, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix parent population color picker
1 participant