Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] segregate automatic "system user" notes from curator notes in Knowledge statements and sentences #321

Open
stappan opened this issue Oct 16, 2024 · 5 comments
Assignees

Comments

@stappan
Copy link
Collaborator

stappan commented Oct 16, 2024

there is too much noise provided by the system state machine in the Notes section, which makes it difficult to see comments that need to be acted upon.

It would be helpful to by default filter out all "system user notes" state machine changes EXCEPT: Exported and Invalid; since these states provide useful information about the statement/sentence.

Acceptance Criteria:
-by default, show human-created notes & those associated with Invalid and Exported states.
-enable a "show system details" check box to toggle the full display for an individual statement/sentence

@ddelpiano
Copy link
Member

@stappan

-do we/should we need an admin version of this that allows you to do something relevant across many/all statements/sentences?

Do you want the admin version because you want to persist the state of this option in the database?
Meaning, I am visiting statement XYZ, as requested by default we show only the human notes and those that contains an update about invalid or exported states. I use the toggle/checkbox to show system details.
I then move to another statement ABC, still following the default behaviour for the notes, I do my work and then go back to XYZ. Should XYZ still display the system details notes or every time we visit a record we use the defaul behaviour?

Could you please assess the priority of this? thanks

@stappan
Copy link
Collaborator Author

stappan commented Oct 29, 2024

@ddelpiano after further discussion, we don't need the admin version for that. It would be good to know how many statements/sentences have a given system message (e.g., missing axiom, missing destination etc;) but i think this is a lower priority (and likely would be separate from this ask anyway. I think it should be moved to it's own request.

So, Acceptance Criteria:
-by default, show human-created notes & those associated with Invalid and Exported states.
-enable a "show system details" check box to toggle the full display for an individual statement/sentence

Can you please provide the effort estimate? That will help determine priority of when it is added to a sprint.

@ddelpiano
Copy link
Member

between 3 and 6 hours, just because we don't have a design yet, but if it's a simple checkbox in the current UI, it should be 3-4 hours.

@stappan
Copy link
Collaborator Author

stappan commented Nov 13, 2024

@ddelpiano excellent - checkbox it is! let's do this with this sprint please.

@stappan
Copy link
Collaborator Author

stappan commented Nov 13, 2024

in Sprint 22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants