-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android Fullscreen doesn't work in portrait #53
Comments
I am having the same issue. I don't have a fix yet but what I noticed is that if I give the view wrapping the player more height (i.e 800), it works. This is most likely related to |
Hi @jwktje |
@Marcoo09 @7assenTlili Here is a minimal example of when the issue occurs. This code works fine in fullscreen on iOS, but on Android it doesn't.
For me at least, when running this on an Android device the "fullscreen" opens in a huge white page like in my earlier screenshot. This only goes away if you do any of the following;
It seems that basically the app needs to be triggered to reconsider the Webview height after going full screen. And when it does that, it fixes itself. But upon initial pressing of fullscreen, the layout is broken. |
@jwktje thanks for the information. I've tried this on a couple of physical Android devices with different OS versions, but it works for me. |
Can we manually remove fullscreen option? |
why does in iOS when play button is clicked video plays in fullscreen? @Marcoo09 |
@nupurpurohit In your Vimeo account settings, you can hide the fullscreen button for your videos. |
|
Running Expo Go on a physical Android device, the Fullscreen behaviour seems broken.
When I press play inline, it all works well. When I then press fullscreen, it shows the player in a large white webview.
Here is the strange thing. When I minimize the app (as in; navigate away but don't kill Expo go) and come back, it shows correctly in a portrait fullscreen view. Also if I press the Android rotate button on the bottom right (which I don't know if all versions have) it works fine in landscape.
On iOS I also have no problems. So it really boils down to Android in Portrait upon first pressing the fullscreen button.
Check out this screenshot that shows my issue.
I really want to solve this. What can I do to get this issue resolved?
The text was updated successfully, but these errors were encountered: