feat: detect incoming transactions using accounts API #4927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support pagination. Support transaction limit.
Rename last fetched state. Add logging to wipe transactions. Refactor remote transaction source.
Always update last fetched timestamps. Remove block tracker references in unit tests.
Move cache logic into remote transaction source. Support queryEntireHistory property. Support updateTransactions property. Support includeTokenTransfers property. Ignore duplicate incoming transactions.
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
@metamaskbot publish-preview |
1 similar comment
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
## Changelog ### `@metamask/queued-request-controller` ## 7.1.0 ### Removed - `createQueuedRequestMiddleware` no longer takes a `useRequestQueue` parameter. All requests are now queued if `shouldEnqueueRequest(req)` returns true. ([#4941](#4941)) ### `@metamask/selected-network-controller ## 19.1.0 ### Removed - The `SelectedNetworkController` constructor no longer expects a `useRequestPreference` boolean nor an `onPreferencesStateChange` listener. Removal of these parameters means that `domains` state will always be added for sites that are granted permissions. ([#4941](#4941)) --------- Co-authored-by: Mark Stacey <[email protected]>
Major release of `@metamask/transaction-controller` to remove global network usage. Major release of `@metamask/user-operation-controller` due to dependency.
…oved (#4978) ## Explanation Updates the CAIP-25 mutators so that if the only eip155 account or scope is removed then the entire permission is revoked. ## References Related: MetaMask/metamask-extension#28709 ## Changelog <!-- If you're making any consumer-facing changes, list those changes here as if you were updating a changelog, using the template below as a guide. (CATEGORY is one of BREAKING, ADDED, CHANGED, DEPRECATED, REMOVED, or FIXED. For security-related issues, follow the Security Advisory process.) Please take care to name the exact pieces of the API you've added or changed (e.g. types, interfaces, functions, or methods). If there are any breaking changes, make sure to offer a solution for consumers to follow once they upgrade to the changes. Finally, if you're only making changes to development scripts or tests, you may replace the template below with "None". --> ### `@metamask/multichain` - **CHANGED**: `Caip25CaveatMutators.authorizedScopes.removeAccount` now revokes the CAIP-25 endowment if the only account is removed. - **CHANGED**: `Caip25CaveatMutators.authorizedScopes.removeScope` now revokes the CAIP-25 endowment if the only non-wallet scope is removed. - **CHANGED**: `setEthAccounts` no longer adds `wallet:eip155` to the optionalScopes if it does not already exist. ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [x] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes --------- Co-authored-by: Alex Donesky <[email protected]>
Release Multichain minor for mutator changes
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Poll for incoming transactions using the accounts API rather than Etherscan.
Specifically:
PollingBlockTracker.etherscanutil andEtherscanRemoteTransactionSource.accounts-apiutil andAccountsApiRemoteTransactionSource.ETHERSCAN_SUPPORTED_NETWORKSconstant.IncomingTransactionHelper.IncomingTransactionHelperinstance creation fromMultichainTrackingHelper.RemoteTransactionSourceviagetCacheandupdateCacheproperties.References
Changelog
See
CHANGELOG.md.Checklist