From d39b4a575302c9570fbfe712ece0a9c29665ae45 Mon Sep 17 00:00:00 2001 From: Norbert Elter <72046715+itsyoboieltr@users.noreply.github.com> Date: Thu, 27 Jun 2024 20:26:15 +0200 Subject: [PATCH 01/22] feat: run-unit-tests --- .github/workflows/run-unit-tests.yml | 41 ++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) create mode 100644 .github/workflows/run-unit-tests.yml diff --git a/.github/workflows/run-unit-tests.yml b/.github/workflows/run-unit-tests.yml new file mode 100644 index 000000000000..01b9c0c4b110 --- /dev/null +++ b/.github/workflows/run-unit-tests.yml @@ -0,0 +1,41 @@ +name: Run unit tests + +on: + pull_request + +jobs: + test-unit-jest: + runs-on: ubuntu-latest + steps: + - name: Checkout repository + uses: actions/checkout@v4 + + - name: Setup Node.js + uses: actions/setup-node@v4 + with: + node-version-file: '.nvmrc' + cache: 'yarn' + + - name: Install dependencies + run: yarn --immutable + + - name: test:coverage:jest + run: yarn test:coverage:jest + + test-unit-jest-development: + runs-on: ubuntu-latest + steps: + - name: Checkout repository + uses: actions/checkout@v4 + + - name: Setup Node.js + uses: actions/setup-node@v4 + with: + node-version-file: '.nvmrc' + cache: 'yarn' + + - name: Install dependencies + run: yarn --immutable + + - name: test:coverage:jest:dev + run: yarn test:coverage:jest:dev From f353ab57500f299fde953700113612b65d5d5423 Mon Sep 17 00:00:00 2001 From: Norbert Elter <72046715+itsyoboieltr@users.noreply.github.com> Date: Fri, 28 Jun 2024 20:35:32 +0200 Subject: [PATCH 02/22] fix: add corepack enable --- .github/workflows/run-unit-tests.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/run-unit-tests.yml b/.github/workflows/run-unit-tests.yml index 01b9c0c4b110..7987d47f1c3c 100644 --- a/.github/workflows/run-unit-tests.yml +++ b/.github/workflows/run-unit-tests.yml @@ -16,6 +16,8 @@ jobs: node-version-file: '.nvmrc' cache: 'yarn' + - run: corepack enable + - name: Install dependencies run: yarn --immutable From a399875d60b60920301019f326fed00276789356 Mon Sep 17 00:00:00 2001 From: Norbert Elter <72046715+itsyoboieltr@users.noreply.github.com> Date: Fri, 28 Jun 2024 20:39:39 +0200 Subject: [PATCH 03/22] fix: corepack enable --- .github/workflows/run-unit-tests.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/run-unit-tests.yml b/.github/workflows/run-unit-tests.yml index 7987d47f1c3c..0bb1d9fcdf0a 100644 --- a/.github/workflows/run-unit-tests.yml +++ b/.github/workflows/run-unit-tests.yml @@ -36,6 +36,8 @@ jobs: node-version-file: '.nvmrc' cache: 'yarn' + - run: corepack enable + - name: Install dependencies run: yarn --immutable From b6788805fe2a0c901a6873a2d799f46913f94ac3 Mon Sep 17 00:00:00 2001 From: Norbert Elter <72046715+itsyoboieltr@users.noreply.github.com> Date: Fri, 28 Jun 2024 23:01:27 +0200 Subject: [PATCH 04/22] fix: remove unit tests from config --- .circleci/config.yml | 64 -------------------------------------------- 1 file changed, 64 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 5ab0af8fb0cc..be6f2b4e772f 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -230,16 +230,6 @@ workflows: - /^Version-v(\d+)[.](\d+)[.](\d+)/ requires: - prep-build - - test-unit-jest-main: - requires: - - prep-deps - - test-unit-jest-development: - requires: - - prep-deps - - upload-coverage: - requires: - - test-unit-jest-main - - test-unit-jest-development - test-unit-global: requires: - prep-deps @@ -283,10 +273,7 @@ workflows: - test-lint-shellcheck - test-lint-lockfile - test-lint-changelog - - test-unit-jest-main - - test-unit-jest-development - test-unit-global - - upload-coverage - validate-source-maps - validate-source-maps-beta - validate-source-maps-flask @@ -1559,9 +1546,6 @@ jobs: path: builds-test - store_artifacts: path: builds-test-flask - - store_artifacts: - path: coverage - destination: coverage - store_artifacts: path: test-artifacts destination: test-artifacts @@ -1642,54 +1626,6 @@ jobs: git config user.email metamaskbot@users.noreply.github.com yarn ts-migration:dashboard:deploy - test-unit-jest-development: - executor: node-browsers-small - steps: - - run: *shallow-git-clone - - run: sudo corepack enable - - attach_workspace: - at: . - - run: - name: jest development unit tests - command: yarn test:coverage:jest:dev - - persist_to_workspace: - root: . - paths: - - coverage - - store_test_results: - path: test/test-results/junit.xml - - test-unit-jest-main: - executor: node-browsers-medium-plus - parallelism: 8 - steps: - - run: *shallow-git-clone - - run: sudo corepack enable - - attach_workspace: - at: . - - run: - name: test:coverage:jest - command: yarn test:coverage:jest - - persist_to_workspace: - root: . - paths: - - coverage - - store_test_results: - path: test/test-results/junit.xml - - upload-coverage: - executor: node-browsers-small - steps: - - run: *shallow-git-clone - - run: sudo corepack enable - - attach_workspace: - at: . - - codecov/upload - - persist_to_workspace: - root: . - paths: - - coverage - test-unit-global: executor: node-browsers-small steps: From 9b8917e102eccfdc5a5a74b64944d6ada20463d5 Mon Sep 17 00:00:00 2001 From: Norbert Elter <72046715+itsyoboieltr@users.noreply.github.com> Date: Fri, 28 Jun 2024 23:01:36 +0200 Subject: [PATCH 05/22] fix: add pr action types --- .github/workflows/run-unit-tests.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/run-unit-tests.yml b/.github/workflows/run-unit-tests.yml index 0bb1d9fcdf0a..4ece13606c91 100644 --- a/.github/workflows/run-unit-tests.yml +++ b/.github/workflows/run-unit-tests.yml @@ -1,7 +1,8 @@ name: Run unit tests on: - pull_request + pull_request: + types: [opened,reopened,synchronize] jobs: test-unit-jest: From ce188315d16ed206cd67a20225060b1be38d51f7 Mon Sep 17 00:00:00 2001 From: Norbert Elter <72046715+itsyoboieltr@users.noreply.github.com> Date: Fri, 28 Jun 2024 23:04:40 +0200 Subject: [PATCH 06/22] fix: setup nodejs --- .github/workflows/run-unit-tests.yml | 26 ++++++++++++++++++-------- 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/.github/workflows/run-unit-tests.yml b/.github/workflows/run-unit-tests.yml index 4ece13606c91..1b8b5020ce66 100644 --- a/.github/workflows/run-unit-tests.yml +++ b/.github/workflows/run-unit-tests.yml @@ -8,16 +8,21 @@ jobs: test-unit-jest: runs-on: ubuntu-latest steps: + - name: Setup Node.js + uses: actions/setup-node@v4 + with: + node-version: 'lts/*' + + - run: corepack enable + - name: Checkout repository uses: actions/checkout@v4 - - name: Setup Node.js + - name: Set up Node.js uses: actions/setup-node@v4 with: node-version-file: '.nvmrc' - cache: 'yarn' - - - run: corepack enable + cache: yarn - name: Install dependencies run: yarn --immutable @@ -28,16 +33,21 @@ jobs: test-unit-jest-development: runs-on: ubuntu-latest steps: + - name: Setup Node.js + uses: actions/setup-node@v4 + with: + node-version: 'lts/*' + + - run: corepack enable + - name: Checkout repository uses: actions/checkout@v4 - - name: Setup Node.js + - name: Set up Node.js uses: actions/setup-node@v4 with: node-version-file: '.nvmrc' - cache: 'yarn' - - - run: corepack enable + cache: yarn - name: Install dependencies run: yarn --immutable From 335744f446af140db968b8147b03c33e2fba83a5 Mon Sep 17 00:00:00 2001 From: Norbert Elter <72046715+itsyoboieltr@users.noreply.github.com> Date: Mon, 1 Jul 2024 13:33:45 +0200 Subject: [PATCH 07/22] feat: add codecov upload --- .github/workflows/run-unit-tests.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/run-unit-tests.yml b/.github/workflows/run-unit-tests.yml index 1b8b5020ce66..bf5a9a3966a9 100644 --- a/.github/workflows/run-unit-tests.yml +++ b/.github/workflows/run-unit-tests.yml @@ -30,6 +30,8 @@ jobs: - name: test:coverage:jest run: yarn test:coverage:jest + - uses: codecov/codecov-action@v4 + test-unit-jest-development: runs-on: ubuntu-latest steps: @@ -54,3 +56,5 @@ jobs: - name: test:coverage:jest:dev run: yarn test:coverage:jest:dev + + - uses: codecov/codecov-action@v4 From 697f8eca60dcd92a3c30c5ef6fa0b2e152ce2aed Mon Sep 17 00:00:00 2001 From: Norbert Elter <72046715+itsyoboieltr@users.noreply.github.com> Date: Mon, 1 Jul 2024 16:20:27 +0200 Subject: [PATCH 08/22] fix: test I would be honestly surprised if this worked --- .github/workflows/run-unit-tests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/run-unit-tests.yml b/.github/workflows/run-unit-tests.yml index bf5a9a3966a9..1597dd92eefa 100644 --- a/.github/workflows/run-unit-tests.yml +++ b/.github/workflows/run-unit-tests.yml @@ -30,7 +30,7 @@ jobs: - name: test:coverage:jest run: yarn test:coverage:jest - - uses: codecov/codecov-action@v4 + - uses: codecov/codecov-action@d9f34f8cd5cb3b3eb79b3e4b5dae3a16df499a70 test-unit-jest-development: runs-on: ubuntu-latest @@ -57,4 +57,4 @@ jobs: - name: test:coverage:jest:dev run: yarn test:coverage:jest:dev - - uses: codecov/codecov-action@v4 + - uses: codecov/codecov-action@d9f34f8cd5cb3b3eb79b3e4b5dae3a16df499a70 From 6b03bd33972179fbd915f1db99d5065016d5953f Mon Sep 17 00:00:00 2001 From: Norbert Elter <72046715+itsyoboieltr@users.noreply.github.com> Date: Mon, 1 Jul 2024 17:49:18 +0200 Subject: [PATCH 09/22] fix: add token and fail on error --- .github/workflows/run-unit-tests.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/run-unit-tests.yml b/.github/workflows/run-unit-tests.yml index 1597dd92eefa..e981070aebb7 100644 --- a/.github/workflows/run-unit-tests.yml +++ b/.github/workflows/run-unit-tests.yml @@ -31,6 +31,9 @@ jobs: run: yarn test:coverage:jest - uses: codecov/codecov-action@d9f34f8cd5cb3b3eb79b3e4b5dae3a16df499a70 + with: + token: ${{ secrets.CODECOV_TOKEN }} + fail_ci_if_error: true test-unit-jest-development: runs-on: ubuntu-latest @@ -58,3 +61,6 @@ jobs: run: yarn test:coverage:jest:dev - uses: codecov/codecov-action@d9f34f8cd5cb3b3eb79b3e4b5dae3a16df499a70 + with: + token: ${{ secrets.CODECOV_TOKEN }} + fail_ci_if_error: true From 9711df5bc620f355129274a3defaa858ad24c1db Mon Sep 17 00:00:00 2001 From: Norbert Elter <72046715+itsyoboieltr@users.noreply.github.com> Date: Tue, 2 Jul 2024 14:38:17 +0200 Subject: [PATCH 10/22] Update config.yml --- .circleci/config.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 45ab5c1be27c..6cda65fae286 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -249,7 +249,6 @@ workflows: - /^Version-v(\d+)[.](\d+)[.](\d+)/ requires: - prep-build - - get-changed-files-with-git-diff - test-unit-global: requires: - prep-deps From 042fe6f2cc3aa55756eda3fe01171c67a69b5eee Mon Sep 17 00:00:00 2001 From: Norbert Elter <72046715+itsyoboieltr@users.noreply.github.com> Date: Wed, 3 Jul 2024 16:18:06 +0200 Subject: [PATCH 11/22] feat: setup-environment reusable workflow --- .github/workflows/run-unit-tests.yml | 50 ++----------------------- .github/workflows/setup-environment.yml | 35 +++++++++++++++++ 2 files changed, 38 insertions(+), 47 deletions(-) create mode 100644 .github/workflows/setup-environment.yml diff --git a/.github/workflows/run-unit-tests.yml b/.github/workflows/run-unit-tests.yml index e981070aebb7..868610926599 100644 --- a/.github/workflows/run-unit-tests.yml +++ b/.github/workflows/run-unit-tests.yml @@ -8,24 +8,10 @@ jobs: test-unit-jest: runs-on: ubuntu-latest steps: - - name: Setup Node.js - uses: actions/setup-node@v4 - with: - node-version: 'lts/*' - - - run: corepack enable - - - name: Checkout repository - uses: actions/checkout@v4 + - uses: ./.github/workflows/setup-environment.yml - - name: Set up Node.js - uses: actions/setup-node@v4 - with: - node-version-file: '.nvmrc' - cache: yarn - - - name: Install dependencies - run: yarn --immutable + - name: test:coverage:jest:dev + run: yarn test:coverage:jest:dev - name: test:coverage:jest run: yarn test:coverage:jest @@ -34,33 +20,3 @@ jobs: with: token: ${{ secrets.CODECOV_TOKEN }} fail_ci_if_error: true - - test-unit-jest-development: - runs-on: ubuntu-latest - steps: - - name: Setup Node.js - uses: actions/setup-node@v4 - with: - node-version: 'lts/*' - - - run: corepack enable - - - name: Checkout repository - uses: actions/checkout@v4 - - - name: Set up Node.js - uses: actions/setup-node@v4 - with: - node-version-file: '.nvmrc' - cache: yarn - - - name: Install dependencies - run: yarn --immutable - - - name: test:coverage:jest:dev - run: yarn test:coverage:jest:dev - - - uses: codecov/codecov-action@d9f34f8cd5cb3b3eb79b3e4b5dae3a16df499a70 - with: - token: ${{ secrets.CODECOV_TOKEN }} - fail_ci_if_error: true diff --git a/.github/workflows/setup-environment.yml b/.github/workflows/setup-environment.yml new file mode 100644 index 000000000000..9235f02e4b95 --- /dev/null +++ b/.github/workflows/setup-environment.yml @@ -0,0 +1,35 @@ +name: Setup environment + +on: + workflow_call: + inputs: + fetch-depth: + description: Number of commits to fetch. 0 indicates all history for all branches and tags. + default: 1 + required: false + type: number + +jobs: + setup-environment: + runs-on: ubuntu-latest + steps: + - name: Setup Node.js + uses: actions/setup-node@v4 + with: + node-version: 'lts/*' + + - run: corepack enable + + - name: Checkout repository + uses: actions/checkout@v4 + with: + fetch-depth: ${{ inputs.fetch-depth }} + + - name: Set up Node.js + uses: actions/setup-node@v4 + with: + node-version-file: '.nvmrc' + cache: yarn + + - name: Install dependencies + run: yarn --immutable From 4b3f0cd61bc4c1887723ec96252719cbc8a04e1e Mon Sep 17 00:00:00 2001 From: Norbert Elter <72046715+itsyoboieltr@users.noreply.github.com> Date: Wed, 3 Jul 2024 16:21:27 +0200 Subject: [PATCH 12/22] fix: checkout --- .github/workflows/run-unit-tests.yml | 6 +++++- .github/workflows/setup-environment.yml | 11 ----------- 2 files changed, 5 insertions(+), 12 deletions(-) diff --git a/.github/workflows/run-unit-tests.yml b/.github/workflows/run-unit-tests.yml index 868610926599..b9b14c32e996 100644 --- a/.github/workflows/run-unit-tests.yml +++ b/.github/workflows/run-unit-tests.yml @@ -8,7 +8,11 @@ jobs: test-unit-jest: runs-on: ubuntu-latest steps: - - uses: ./.github/workflows/setup-environment.yml + - name: Checkout repository + uses: actions/checkout@v4 + + - name: Setup environment + uses: ./.github/workflows/setup-environment.yml - name: test:coverage:jest:dev run: yarn test:coverage:jest:dev diff --git a/.github/workflows/setup-environment.yml b/.github/workflows/setup-environment.yml index 9235f02e4b95..ba0e575181e5 100644 --- a/.github/workflows/setup-environment.yml +++ b/.github/workflows/setup-environment.yml @@ -2,12 +2,6 @@ name: Setup environment on: workflow_call: - inputs: - fetch-depth: - description: Number of commits to fetch. 0 indicates all history for all branches and tags. - default: 1 - required: false - type: number jobs: setup-environment: @@ -20,11 +14,6 @@ jobs: - run: corepack enable - - name: Checkout repository - uses: actions/checkout@v4 - with: - fetch-depth: ${{ inputs.fetch-depth }} - - name: Set up Node.js uses: actions/setup-node@v4 with: From ce890f943406a0250a14ef830210e862ab356efa Mon Sep 17 00:00:00 2001 From: Norbert Elter <72046715+itsyoboieltr@users.noreply.github.com> Date: Wed, 3 Jul 2024 16:29:00 +0200 Subject: [PATCH 13/22] Update run-unit-tests.yml --- .github/workflows/run-unit-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/run-unit-tests.yml b/.github/workflows/run-unit-tests.yml index b9b14c32e996..6ebd343898d6 100644 --- a/.github/workflows/run-unit-tests.yml +++ b/.github/workflows/run-unit-tests.yml @@ -12,7 +12,7 @@ jobs: uses: actions/checkout@v4 - name: Setup environment - uses: ./.github/workflows/setup-environment.yml + uses: MetaMask/metamask-extension/.github/workflows/setup-environment.yml@move-unit-tests-to-github-actions - name: test:coverage:jest:dev run: yarn test:coverage:jest:dev From 97eb64ee15798cc6080a2221fd1ef03b3ee9835e Mon Sep 17 00:00:00 2001 From: Norbert Elter <72046715+itsyoboieltr@users.noreply.github.com> Date: Wed, 3 Jul 2024 16:47:11 +0200 Subject: [PATCH 14/22] fix: composite action --- .github/actions/setup-environment/action.yml | 20 ++++++++++++++++ .github/workflows/run-unit-tests.yml | 2 +- .github/workflows/setup-environment.yml | 24 -------------------- 3 files changed, 21 insertions(+), 25 deletions(-) create mode 100644 .github/actions/setup-environment/action.yml delete mode 100644 .github/workflows/setup-environment.yml diff --git a/.github/actions/setup-environment/action.yml b/.github/actions/setup-environment/action.yml new file mode 100644 index 000000000000..0236e3f30961 --- /dev/null +++ b/.github/actions/setup-environment/action.yml @@ -0,0 +1,20 @@ +name: 'Setup environment' +description: 'Setup environment' +runs: + using: 'composite' + steps: + - name: Setup Node.js + uses: actions/setup-node@v4 + with: + node-version: 'lts/*' + + - run: corepack enable + + - name: Set up Node.js + uses: actions/setup-node@v4 + with: + node-version-file: '.nvmrc' + cache: yarn + + - name: Install dependencies + run: yarn --immutable diff --git a/.github/workflows/run-unit-tests.yml b/.github/workflows/run-unit-tests.yml index 6ebd343898d6..8cf0c634611c 100644 --- a/.github/workflows/run-unit-tests.yml +++ b/.github/workflows/run-unit-tests.yml @@ -12,7 +12,7 @@ jobs: uses: actions/checkout@v4 - name: Setup environment - uses: MetaMask/metamask-extension/.github/workflows/setup-environment.yml@move-unit-tests-to-github-actions + uses: ./.github/actions/setup-environment - name: test:coverage:jest:dev run: yarn test:coverage:jest:dev diff --git a/.github/workflows/setup-environment.yml b/.github/workflows/setup-environment.yml deleted file mode 100644 index ba0e575181e5..000000000000 --- a/.github/workflows/setup-environment.yml +++ /dev/null @@ -1,24 +0,0 @@ -name: Setup environment - -on: - workflow_call: - -jobs: - setup-environment: - runs-on: ubuntu-latest - steps: - - name: Setup Node.js - uses: actions/setup-node@v4 - with: - node-version: 'lts/*' - - - run: corepack enable - - - name: Set up Node.js - uses: actions/setup-node@v4 - with: - node-version-file: '.nvmrc' - cache: yarn - - - name: Install dependencies - run: yarn --immutable From 6814ed16de24838cc11f83278c3117c4c506dc0c Mon Sep 17 00:00:00 2001 From: Norbert Elter <72046715+itsyoboieltr@users.noreply.github.com> Date: Wed, 3 Jul 2024 16:51:34 +0200 Subject: [PATCH 15/22] Update action.yml --- .github/actions/setup-environment/action.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/actions/setup-environment/action.yml b/.github/actions/setup-environment/action.yml index 0236e3f30961..6b526045b103 100644 --- a/.github/actions/setup-environment/action.yml +++ b/.github/actions/setup-environment/action.yml @@ -2,6 +2,7 @@ name: 'Setup environment' description: 'Setup environment' runs: using: 'composite' + shell: bash steps: - name: Setup Node.js uses: actions/setup-node@v4 From c6a493362093876cd795df8a5e0fc406b9f30386 Mon Sep 17 00:00:00 2001 From: Norbert Elter <72046715+itsyoboieltr@users.noreply.github.com> Date: Wed, 3 Jul 2024 16:53:17 +0200 Subject: [PATCH 16/22] Update action.yml --- .github/actions/setup-environment/action.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/actions/setup-environment/action.yml b/.github/actions/setup-environment/action.yml index 6b526045b103..194ea2e546a3 100644 --- a/.github/actions/setup-environment/action.yml +++ b/.github/actions/setup-environment/action.yml @@ -2,7 +2,6 @@ name: 'Setup environment' description: 'Setup environment' runs: using: 'composite' - shell: bash steps: - name: Setup Node.js uses: actions/setup-node@v4 @@ -10,6 +9,7 @@ runs: node-version: 'lts/*' - run: corepack enable + shell: bash - name: Set up Node.js uses: actions/setup-node@v4 @@ -19,3 +19,4 @@ runs: - name: Install dependencies run: yarn --immutable + shell: bash From 6f6fbf66ec62d95b1ff8e80a9639e187b291a560 Mon Sep 17 00:00:00 2001 From: Norbert Elter <72046715+itsyoboieltr@users.noreply.github.com> Date: Wed, 3 Jul 2024 17:03:57 +0200 Subject: [PATCH 17/22] Update config.yml --- .circleci/config.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 6cda65fae286..43be091c8b7b 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -1158,7 +1158,7 @@ jobs: fi no_output_timeout: 5m environment: - ENABLE_CONFIRMATION_REDESIGN: 'true' + ENABLE_CONFIRMATION_REDESIGN: "true" - store_artifacts: path: test-artifacts destination: test-artifacts @@ -1449,7 +1449,7 @@ jobs: fi no_output_timeout: 5m environment: - ENABLE_CONFIRMATION_REDESIGN: 'true' + ENABLE_CONFIRMATION_REDESIGN: "true" - store_artifacts: path: test-artifacts destination: test-artifacts From 32cdf0353779b75c792f42d9003f2cb6e17f492f Mon Sep 17 00:00:00 2001 From: Norbert Elter <72046715+itsyoboieltr@users.noreply.github.com> Date: Wed, 3 Jul 2024 17:35:22 +0200 Subject: [PATCH 18/22] Update action.yml --- .github/actions/setup-environment/action.yml | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/.github/actions/setup-environment/action.yml b/.github/actions/setup-environment/action.yml index 194ea2e546a3..a014f0099699 100644 --- a/.github/actions/setup-environment/action.yml +++ b/.github/actions/setup-environment/action.yml @@ -3,20 +3,15 @@ description: 'Setup environment' runs: using: 'composite' steps: - - name: Setup Node.js - uses: actions/setup-node@v4 - with: - node-version: 'lts/*' - - - run: corepack enable - shell: bash - - name: Set up Node.js uses: actions/setup-node@v4 with: node-version-file: '.nvmrc' cache: yarn + - run: corepack enable + shell: bash + - name: Install dependencies run: yarn --immutable shell: bash From 62c2e939ccdd0aaf9f5918bc67803721e7bffae8 Mon Sep 17 00:00:00 2001 From: Norbert Elter <72046715+itsyoboieltr@users.noreply.github.com> Date: Wed, 3 Jul 2024 17:40:30 +0200 Subject: [PATCH 19/22] Update action.yml --- .github/actions/setup-environment/action.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/actions/setup-environment/action.yml b/.github/actions/setup-environment/action.yml index a014f0099699..8bdd0ba24c64 100644 --- a/.github/actions/setup-environment/action.yml +++ b/.github/actions/setup-environment/action.yml @@ -3,15 +3,15 @@ description: 'Setup environment' runs: using: 'composite' steps: + - run: corepack enable + shell: bash + - name: Set up Node.js uses: actions/setup-node@v4 with: node-version-file: '.nvmrc' cache: yarn - - run: corepack enable - shell: bash - - name: Install dependencies run: yarn --immutable shell: bash From e63bc823106a4665a2fc514593913f0bc131c25a Mon Sep 17 00:00:00 2001 From: Norbert Elter <72046715+itsyoboieltr@users.noreply.github.com> Date: Wed, 3 Jul 2024 18:03:05 +0200 Subject: [PATCH 20/22] Update run-unit-tests.yml --- .github/workflows/run-unit-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/run-unit-tests.yml b/.github/workflows/run-unit-tests.yml index 8cf0c634611c..ea473de0142f 100644 --- a/.github/workflows/run-unit-tests.yml +++ b/.github/workflows/run-unit-tests.yml @@ -20,7 +20,7 @@ jobs: - name: test:coverage:jest run: yarn test:coverage:jest - - uses: codecov/codecov-action@d9f34f8cd5cb3b3eb79b3e4b5dae3a16df499a70 + - uses: codecov/codecov-action@v4 with: token: ${{ secrets.CODECOV_TOKEN }} fail_ci_if_error: true From 15797c2f9c396c96af48eec8d4bcca57f627a75d Mon Sep 17 00:00:00 2001 From: Norbert Elter <72046715+itsyoboieltr@users.noreply.github.com> Date: Wed, 3 Jul 2024 18:14:59 +0200 Subject: [PATCH 21/22] Update run-unit-tests.yml --- .github/workflows/run-unit-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/run-unit-tests.yml b/.github/workflows/run-unit-tests.yml index ea473de0142f..56308687b24a 100644 --- a/.github/workflows/run-unit-tests.yml +++ b/.github/workflows/run-unit-tests.yml @@ -20,7 +20,7 @@ jobs: - name: test:coverage:jest run: yarn test:coverage:jest - - uses: codecov/codecov-action@v4 + - uses: codecov/codecov-action@e28ff129e5465c2c0dcc6f003fc735cb6ae0c673 with: token: ${{ secrets.CODECOV_TOKEN }} fail_ci_if_error: true From d1be00909ff6775381473073b7ed6adaf39fc093 Mon Sep 17 00:00:00 2001 From: Norbert Elter <72046715+itsyoboieltr@users.noreply.github.com> Date: Thu, 4 Jul 2024 15:32:09 +0200 Subject: [PATCH 22/22] fix: add warning --- .github/workflows/run-unit-tests.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/run-unit-tests.yml b/.github/workflows/run-unit-tests.yml index 56308687b24a..6b0d0958471b 100644 --- a/.github/workflows/run-unit-tests.yml +++ b/.github/workflows/run-unit-tests.yml @@ -1,3 +1,9 @@ +# WARNING! It is currently being investigated how to make this faster +# DO NOT blindly copy this workflow, not noticing the slow down, +# because suddenly our tests will take hours to pass CI. +# Hopefully this comment here will help prevent that. +# https://github.com/MetaMask/metamask-extension/issues/25680 + name: Run unit tests on: