Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick registry fix to RC #1670

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Conversation

FrederikBolding
Copy link
Member

Cherry picks the registry fix to the RC.

* Fix parallel usage of registry

* Update coverage

* Use doc strings
@FrederikBolding FrederikBolding requested a review from a team as a code owner August 15, 2023 11:38
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #1670 (654376a) into rc/1.0.0 (83bcf35) will increase coverage by 0.00%.
Report is 2 commits behind head on rc/1.0.0.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           rc/1.0.0    #1670   +/-   ##
=========================================
  Coverage     95.89%   95.90%           
=========================================
  Files           146      146           
  Lines          4454     4464   +10     
  Branches        734      736    +2     
=========================================
+ Hits           4271     4281   +10     
  Misses          183      183           
Files Changed Coverage Δ
...kages/snaps-controllers/src/snaps/registry/json.ts 100.00% <100.00%> (ø)

@Gudahtt Gudahtt merged commit e62325e into rc/1.0.0 Aug 15, 2023
61 checks passed
@Gudahtt Gudahtt deleted the fb/cherry-pick-registry-fix branch August 15, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants