-
-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update instances of collectibles to nfts #199
base: main
Are you sure you want to change the base?
Conversation
586eadb
to
5422dc3
Compare
5422dc3
to
cf1822c
Compare
In a recent PR, the source code for the old "Collectibles" contract was added to the repository (in the |
cf1822c
to
c7f03b7
Compare
@@ -1,25 +1,21 @@ | |||
// SPDX-License-Identifier: MIT | |||
pragma solidity >=0.4.22 <0.9.0; | |||
|
|||
import "@openzeppelin/contracts/token/ERC721/ERC721.sol"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I tried compiling this in Remix but got an error about Strings
already being declared. I don't quite understand why, but, it went away with I removed the @4.8.1
or added it to the other two imports. Perhaps they should all be using the same version of @openzeppelin/contracts
.
This PR is to update
collectibles
tonfts
.Reference: MetaMask/metamask-extension#16889
Code for Abis and bytecode: