Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make time split clearer when working with slices #68

Closed
louisPoulain opened this issue Nov 8, 2024 · 0 comments · Fixed by #69
Closed

Make time split clearer when working with slices #68

louisPoulain opened this issue Nov 8, 2024 · 0 comments · Fixed by #69
Assignees
@louisPoulain
Labels
enhancement New feature or request

Comments

@louisPoulain
Copy link
Collaborator

If a user uses start_date and end_date to define a time split, the current implementation include the time step "T00" (0h UTC) for the day given as end_date. However, we do not include other time steps that could occur on this day.
To make it clearer, I would suggest to a strict inequality for the end_date side of the slice.
@louisPoulain louisPoulain added the enhancement New feature or request label Nov 8, 2024
@louisPoulain louisPoulain self-assigned this Nov 8, 2024
@louisPoulain louisPoulain linked a pull request Nov 8, 2024 that will close this issue
Use strict inequality for more clarity #69
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@louisPoulain louisPoulain

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use strict inequality for more clarity MeteoSwiss/mlpp-lib
1 participant
@louisPoulain