Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotnet 8 updates #14

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

dotnet 8 updates #14

wants to merge 3 commits into from

Conversation

alexwolfmsft
Copy link

No description provided.

@alexwolfmsft alexwolfmsft changed the title updates dotnet 8 updates Oct 23, 2023
jamesmontemagno
jamesmontemagno reviewed Oct 23, 2023
View reviewed changes
ContosoPizza/ContosoPizza.csproj Outdated
Comment on lines 10 to 15
<PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite" Version="8.0.*" />
<PackageReference Include="Microsoft.EntityFrameworkCore.Tools" Version="8.0.*">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Design" Version="7.0.6" />
<PackageReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Design" Version="8.0.*" />
Copy link

@jamesmontemagno jamesmontemagno Oct 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be able to do 8.0.*-*

@jamesmontemagno
Copy link

I think also want to update this to net8.0 https://github.com/MicrosoftDocs/mslearn-create-razor-pages-aspnet-core/blob/main/ContosoPizza/ContosoPizza.csproj#L4

@jamesmontemagno
Copy link

Also, can you go through and maybe do all new top level namespaces https://github.com/MicrosoftDocs/mslearn-create-razor-pages-aspnet-core/blob/main/ContosoPizza/Services/PizzaService.cs#L4

a bunch of files that need that updated

@alexwolfmsft
Copy link
Author

I think also want to update this to net8.0 https://github.com/MicrosoftDocs/mslearn-create-razor-pages-aspnet-core/blob/main/ContosoPizza/ContosoPizza.csproj#L4

Forgot to push the latest commit with this

@jamesmontemagno
Copy link

@alexwolfmsft did we update the learn module?

@alexwolfmsft
Copy link
Author

#sign-off

@jamesmontemagno
Copy link

@alexwolfmsft are you able to merge this yourself?

@jamesmontemagno
Copy link

@jongalloway can you merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmontemagno jamesmontemagno jamesmontemagno approved these changes

@jongalloway jongalloway jongalloway approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexwolfmsft @jamesmontemagno @jongalloway