refactor: introduce a DummyInput wrapper
#253
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`DummyInput` can be used to provide an empty `Input` instance that remembers some state from a previous `Input` instance. In the future we may decide to persist additional state, such as sprint or jump. Currently only sneak is persisted.
Resetting `freeCamera`'s input is pointless immediately before setting `freeCamera = null`.
MattSturgeon
force-pushed
the
refactor-dummyinput
branch
from
dd7d3eb to
77d45c6
Compare
Merged
|
This is currently written for 1.21, I'll rebase it on main to target 1.21.3 and stash these changes in a temp branch as we'll need them for backporting to 1.21 and lower |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DummyInputcan be used to provide an emptyInputinstance that remembers some state from a previousInputinstance.This small refactor adds a
DummyInputclass that extendsInputand takes over the responsibility for persisting the player's "is sneaking" state when the player is not actively being controlled.Freecamclass.Inputclass has been refactored upstream.Currently only sneak is persisted. In the future we may decide to persist additional state, such as sprint or jump.