Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Marker Creation #25

Open
Zoriot opened this issue May 9, 2024 · 3 comments
Open

Simplify Marker Creation #25

Zoriot opened this issue May 9, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@Zoriot
Copy link
Contributor

Zoriot commented May 9, 2024

It would be great if you simplify the Marker Creation more:

  • Allow executing commands from console (So you dont have to tab between BlueMap and Minecraft)
  • Make a Command where you can create a POI Marker with one Command (kinda simular how BlueMarker does with Signs)
  • If some mistyped information, allow discarding last step

Also the Modrinth/Download Links should be added to the Readme & the ToDo Adding a way to edit markers and marker-sets after build/creating them should be removed, bc i think thats already implemented.

@MiraculixxT
Copy link
Owner

Thanks for the suggestions. In the newest version you can create template markers, that allows players to add a new marker based on your template with a single command. This also allows for more complex setups that are automated by e.g. placing named blocks or naming entities (based on placeholders).

You can also use the commands in console, the only downside here is that you can not click on messages to run or suggest other commands. You need to manually type every command by yourself (tho tab complete works).

  • TODO: Revert last step

@MiraculixxT MiraculixxT added the enhancement New feature or request label Jun 17, 2024
@Zoriot
Copy link
Contributor Author

Zoriot commented Dec 8, 2024

14:44:05

4004 issued server command: /btemplate delete zotest true

WARN
14:44:05

Exception in thread "DefaultDispatcher-worker-1" java.lang.ClassCastException: class java.lang.String cannot be cast to class java.lang.Boolean (java.lang.String and java.lang.Boolean are in module java.base of loader 'bootstrap')
	at bmm-paper-2.1.7.jar//de.miraculixx.bmm.commands.TemplateCommand$templateCommand$lambda$11$lambda$10$lambda$9$lambda$8$$inlined$anyExecutorAsync$1$1.invokeSuspend(CommandExtensions.kt:24)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:101)
	at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:589)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:832)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:720)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:707)
	Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [StandaloneCoroutine{Cancelling}@3b391ccc, Dispatchers.Default]

Deleting Marker Templates Seems not to work. (Deleting the Marker Tamplate inside works)

@Zoriot
Copy link
Contributor Author

Zoriot commented Dec 8, 2024

Currently using the Tamplates doesnt really work for line`s. Would be great if you can use that too
When a Map is removed it shows command.template.removeMap => the actual Successful Message should be shown

For us its currently its not really a help because the most people have about 2 markers & we want to mange them.
So the whole thing with own command, template permission, template set is not needed for our use case.
For us it would be just enough if you can make marker tamplates & use them in all sets.
Like /bmarker create <Type/Template> would be great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants