Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash with Create due to Kyori adventure-platform-fabric #6

Open
piebaker opened this issue Feb 1, 2023 · 2 comments
Open

Crash with Create due to Kyori adventure-platform-fabric #6

piebaker opened this issue Feb 1, 2023 · 2 comments

Comments

@piebaker
Copy link

piebaker commented Feb 1, 2023

Link to relevant Create issue: Fabricators-of-Create/Create#503
Link to relevant log: https://mclo.gs/IedCAC6
After removing BMM the server will not crash.
Appears to be an issue with the fake-player-api & create interactions, had the issue with a deployer.
Hoping for a quick fix, love this mod!

@MiraculixxT
Copy link
Owner

MiraculixxT commented Feb 2, 2023

So, i investigate the issue and there is nothing i or adventure could do to fix this error. Adventure uses the default fake player implementation and not really modificate very much except the message channel. That is nothing that should break any other mods.

I am not 100% familiar with Create, but apparently they create their own fake player implementation that is not compatible with the default implementation. That will break every mod that use the default fake player like adventure. Someone in your mentioned thread write that it is not creates fault but as far as i understand this issue, its the fault of Creates implementation but they have to do it for internal reasons or somehting like that.

Maybe Adventure can change stuff to make it work, but i doubt it. I can't do anything to fix it, because BMM is highly depending on Adventures Audience and message system

@piebaker
Copy link
Author

piebaker commented Feb 2, 2023

No worries, good to find the root cause. Might pay to add a disclaimer to description pages that it is incompatible with create. Maybe also leave this issue open, on the off chance a fix is at some point developed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants