Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit command conflicts with yarn|npm audit #162

Open
jaygarcia opened this issue Feb 26, 2020 · 1 comment
Open

audit command conflicts with yarn|npm audit #162

jaygarcia opened this issue Feb 26, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@jaygarcia
Copy link

jaygarcia commented Feb 26, 2020

Describe the bug
After onboarding the project, I learned that our instructions suggest we add 'audit' to npm run scripts. Problem is that it conflicts with npm audit and yarn audit and is not good practice.

image

image

@jaygarcia jaygarcia added the bug Something isn't working label Feb 26, 2020
@mitchellsimoens
Copy link
Collaborator

mitchellsimoens commented Feb 27, 2020

#159 does remove this and you just execute gimbal and it just works. The reason for audit was each audit module was executable individually and audit was the command to run them all... and yea, guess poor choice of name due to the described... just need to get back to v2. I think the only thing todo is since we cannot use actions to get the circleci configs back... and then update things and make sure it all still works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants