Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a developer, I fix the test for the garden destroy. #111

Open
leahriffell opened this issue Nov 4, 2020 · 0 comments
Open

As a developer, I fix the test for the garden destroy. #111

leahriffell opened this issue Nov 4, 2020 · 0 comments

Comments

@leahriffell
Copy link
Contributor

leahriffell commented Nov 4, 2020

Functionality is working but tests failing for delete from dashboard and from garden show page.

Couldn’t figure out how to hit the destroy action in pry and felt that I was spending too much time on it given the functionality is working.

Also the entire test is stubbed and isn’t actually testing anything anyway (as a lot are on the FE). Would like to address these concerns w/ Ian or the group.

Response from Ian regarding above:

Ian Douglas 1:08 PM
in a nutshell, it's tricky to actually test the front end unless you deploy a second copy of the backend and treat that as a "test" or "staging" environment, and set that ENV hostname on Travis for the FE code to hit "for real" and switch to using VCR
without getting into paid Travis "pipeline" environments where it spins up all other services in order to properly run all test suites, there's no easier way than just deploying a second copy of BE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant