Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cutover from workflows API to DAG Launcher #234

Open
1 task
smohiudd opened this issue Oct 7, 2024 · 3 comments
Open
1 task

Cutover from workflows API to DAG Launcher #234

smohiudd opened this issue Oct 7, 2024 · 3 comments

Comments

@smohiudd
Copy link
Contributor

smohiudd commented Oct 7, 2024

Description

The workflows API is used to ingest datasets using Airflow DAGs. With SM2A we have access to the native airflow endpoints which can be used instead of the workflows. API. This ticket involves documenting the differences between Workflows API and SM2A endpoints and any changes needed in SM2A to ingest datasets similar to Workflows.

Acceptance Criteria

  • Verify ingestion process using DAG Launcher/SM2A and parity with Workflows API
@smohiudd
Copy link
Contributor Author

smohiudd commented Nov 20, 2024

Proposal: use simple lambda as proxy for SM2A /dags/{dag_id}/dagRuns instead of using workflows api. Use eventbridge lambda as example with dag name and auth: https://github.com/NASA-IMPACT/veda-data-airflow/blob/dev/sm2a/infrastructure/functions/s3_event_bridge_to_sfn_execute/lambda_function.py#L13

@smohiudd smohiudd changed the title Cutover from workflows API to SM2A endpoints Cutover from workflows API to DAG Launcher Nov 20, 2024
@amarouane-ABDELHAK
Copy link
Contributor

amarouane-ABDELHAK commented Nov 21, 2024

Another option may be to create an SM2A role using Airflow Role-Based Access Control (RBAC) with limited access to the Discover DAG. The allowed users would only be able to see the Discover DAG in the Airflow UI, trigger it using the form, and view the execution of each task. We can control who is assigned as a DAG Launcher using GitHub teams. In the future, we could use another OIDC tool, such as AWS Cognito or Keycloak.

DAGs to add RBAC role for are:

  • VEDA-Discover
  • VEDA-Collection-Pipeline
  • Veda-Dataset-Pipeline

@amarouane-ABDELHAK
Copy link
Contributor

Work will be documented here #269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants