Move components that are used in instances to library entry point #1089
Assignees
Comments
|
@hanbyul-here I tried adding some context based on my understanding of your description this morning, but please add/edit the ticket above to match the needs of this ticket. |
hanbyul-here
added a commit
that referenced
this issue
Aug 15, 2024
**Related Ticket:** #1089 ### Description of Changes Make one entry file for all the components that are used in an instance. I thought about using library entry file, but some of the components will interrupt the library building, and I don't really want to blur the scope of this PR. ### Notes & Questions About Changes This idea was really nice in my brain.. but now that I see the changes, I am not sure if this would be a better way to use the components from VEDA UI or not. It is surely nice that we don't have to worry about moving components around in the source code. But I'm not sure if importing literally everything from veda-ui-scripts is a good idea or not - We can try to have more structured exports, but I don't really want to add any maintenance efforts of this file. This is how it looks like in the instance - it makes the code look a bit unorganized. But it may be fine?: US-GHG-Center/veda-config-ghg@develop...US-GHG-Center:veda-config-ghg:use-etnry-for-instance Can y'all give me your thoughts? @sandrahoang686 @dzole0311 Also @slesaad - How do you think about importing all the components needed from one entry file like this? US-GHG-Center/veda-config-ghg@develop...US-GHG-Center:veda-config-ghg:use-etnry-for-instance#diff-546348a53a9dc4b9a8f244b185ac088f93fe7a5573cfc39617f7e8bd9a471d00R27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context
Now that we have instances starting to use components, we want to control access a bit more and understand who is accessing which components. So, we want to allow easy access through a single entry point.
The text was updated successfully, but these errors were encountered: