Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare analysis page for the datasets without summaries #746

Open
hanbyul-here opened this issue Nov 13, 2023 · 3 comments
Open

Prepare analysis page for the datasets without summaries #746

hanbyul-here opened this issue Nov 13, 2023 · 3 comments
Assignees

Comments

@hanbyul-here
Copy link
Collaborator

hanbyul-here commented Nov 13, 2023

All the collections are supposed to have summaries, but sometimes they are missing this breaks the analysis page totally. We need some basic error handling.

Update:

  • We need to figure out behavior of analysis page when summaries is missing
  • Is there currently any error handling?
  • How do we want to handle empty summaries?
  • How are we handling the summaries on each page right now just for general knowledge?

@danielfdsilva In case this is related to the new a&e page.

@j08lue
Copy link
Contributor

j08lue commented Nov 14, 2023

Oh, awesome you caught that, @hanbyul-here!

I will create a ticket in https://github.com/US-GHG-Center/ghgc-data to fix those collections, too.

Can you name one collection where this issue exists?

@anayeaye
Copy link

@j08lue in VEDA we don't currently have a mechanism to consistently support summaries for collections that redirect to external data so, at the moment, these don't have summaries (but I think the dashboard already takes these into account).

  • eis_fire_fireline
  • eis_fire_newfirepix
  • eis_fire_perimeter

Some recent VEDA ingests were missing summaries that exposed this need but we corrected those yesterday.

@sandrahoang686
Copy link
Collaborator

Thoughts

  • How do we want to handle missing summaries?
  • Identify through out in the application where we handle summaries

sandrahoang686 added a commit that referenced this issue Jan 10, 2024
This aims to solve ticket
[here](#746)

Exploration and Analysis page seems like it already handles summaries
are not available
[here](https://github.com/NASA-IMPACT/veda-ui/pull/769/files) and
[here](https://github.com/NASA-IMPACT/veda-ui/pull/758/files#diff-cf038be4360f19e9ab0d1ea21567952a3c816545a0c23e57906e0f7223a5e769R61)

For Analysis/Results: We dont have to worry because users would not be
able to select the dataset without summaries any longer with this fix

Loom Local Validation: 
https://www.loom.com/share/d0b132ca88b242dc8014e277495d6746

**UPDATE TO FLAG COMMENT:**
![Screenshot 2024-01-04 at 12 34 47
PM](https://github.com/NASA-IMPACT/veda-ui/assets/30272083/6a96fd48-f12f-487d-99ae-4e92d422097b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants