Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommendation to remove a default secret key #79

Open
FHantke opened this issue Sep 17, 2024 · 1 comment
Open

Recommendation to remove a default secret key #79

FHantke opened this issue Sep 17, 2024 · 1 comment

Comments

@FHantke
Copy link

FHantke commented Sep 17, 2024

Hello,

We are a cybersecurity research group from the CISPA Helmholtz Center for Information Security and Ca’ Foscari University of Venice. We recently conducted an analysis of the session management used in your web application as part of our research. We have discovered a security flaw that we believe requires your attention.

Description:

After our analysis, we have identified that your application is using a hard-coded secret key that is leaked through GitHub. If operators who install your web application do not change this secret key, they are vulnerable to cookie forgeries. The cookie forgery attack allows an attacker, knowing the key used to sign a cookie, to forge new arbitrary cookies to impersonate and take over other accounts.

link to the relevant code part 1

link to the relevant code part 2

Recommendation for Mitigation:

To address this issue and enhance the security posture of your web application, we highly recommend setting the secret key from an environment variable. If the environment file is not shared on GitHub then this would force operators of your application to create their own key upon installation, forcing them to set their own secure secret key.

We hope this notification helps improve your security and would appreciate if you could take a look into the relevant code parts and comment on the issue.
Thank you!

@cedricbonhomme
Copy link
Collaborator

Hello !

I agree, will do !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants