-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 0107: Update for spyro Compatibility with Latest Firedrake Installation #119
Conversation
Issue 0050 compatibility
I have also updated the runner file to the correct location of the newest Firedrake installation |
The cell type of some tests was changed from "Q" to "T". Is this a limitation of the newer Firedrake version? |
Not anymore, the newer version of Firedrake now supports both triangles and quadrilaterals. Initially, I switched to using triangles during testing, as Firedrake had some issues with quadrilaterals at the time. Once these problems were resolved, I chose to continue using triangles since they are our usual preference. However, we still have numerous tests based on quadrilaterals. |
Description:
This minor update ensures that spyro is compatible with the latest Firedrake installation. The main changes include: