Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 0107: Update for spyro Compatibility with Latest Firedrake Installation #119

Merged
merged 13 commits into from
Jul 24, 2024

Conversation

Olender
Copy link
Collaborator

@Olender Olender commented Jul 21, 2024

Description:

This minor update ensures that spyro is compatible with the latest Firedrake installation. The main changes include:

  1. Function to Cofunction Conversion: Updated several functions to cofunctions where necessary.
  2. Cleanup: Removed old, unused test and HTML files that were unnecessarily taking up space in the repository.

@Olender Olender linked an issue Jul 21, 2024 that may be closed by this pull request
@Olender
Copy link
Collaborator Author

Olender commented Jul 21, 2024

I have also updated the runner file to the correct location of the newest Firedrake installation

@Olender Olender requested a review from SouzaEM July 22, 2024 17:55
@SouzaEM
Copy link
Collaborator

SouzaEM commented Jul 23, 2024

The cell type of some tests was changed from "Q" to "T". Is this a limitation of the newer Firedrake version?

@Olender
Copy link
Collaborator Author

Olender commented Jul 23, 2024

Not anymore, the newer version of Firedrake now supports both triangles and quadrilaterals. Initially, I switched to using triangles during testing, as Firedrake had some issues with quadrilaterals at the time. Once these problems were resolved, I chose to continue using triangles since they are our usual preference. However, we still have numerous tests based on quadrilaterals.

@Olender Olender merged commit ba573c5 into main Jul 24, 2024
2 checks passed
@Olender Olender deleted the issue_0107_compatibility branch August 20, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility issues with newest Firedrake install
2 participants