-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Stacey boundary condition #131
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #131 +/- ##
==========================================
+ Coverage 84.23% 84.31% +0.08%
==========================================
Files 56 58 +2
Lines 3729 3902 +173
==========================================
+ Hits 3141 3290 +149
- Misses 588 612 +24 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like what you did with the FieldLogger class. Since it has grown a bit and if you have time could you add documentation as well? I think later I will add, in another PR, a File class that writes to binary in cases were firedrake is installed without VTK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So let's open another PR to address the binary format, the documentation, and other new features.
This implementation includes: