Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Stacey boundary condition #131

Merged
merged 7 commits into from
Nov 7, 2024
Merged

Implement Stacey boundary condition #131

merged 7 commits into from
Nov 7, 2024

Conversation

SouzaEM
Copy link
Collaborator

@SouzaEM SouzaEM commented Nov 1, 2024

This implementation includes:

  • Stacey boundary condition itself
  • Modification of field logger to also log functionals
  • Evaluation of mechanical energies to evaluate the boundary condition
  • Regression tests based on the mechanical energy
  • Second order time discretization options for velocities (although they didn't improve performance)

@SouzaEM SouzaEM self-assigned this Nov 1, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 96.44670% with 7 lines in your changes missing coverage. Please review.

Project coverage is 84.31%. Comparing base (a701161) to head (83e95c4).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
spyro/solvers/elastic_wave/local_abc.py 92.63% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
+ Coverage   84.23%   84.31%   +0.08%     
==========================================
  Files          56       58       +2     
  Lines        3729     3902     +173     
==========================================
+ Hits         3141     3290     +149     
- Misses        588      612      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like what you did with the FieldLogger class. Since it has grown a bit and if you have time could you add documentation as well? I think later I will add, in another PR, a File class that writes to binary in cases were firedrake is installed without VTK.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So let's open another PR to address the binary format, the documentation, and other new features.

@SouzaEM SouzaEM merged commit 96a1aad into main Nov 7, 2024
6 checks passed
@SouzaEM SouzaEM deleted the issue_0130_stacey branch November 7, 2024 12:16
@SouzaEM SouzaEM linked an issue Nov 7, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Stacey boundary condition
2 participants