Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 0133 create new spyro version were every dependency not pip installable is optional #137

improvements based on SouzaEM's comments

498354a
Select commit
Loading
Failed to load commit list.
Merged

Issue 0133 create new spyro version were every dependency not pip installable is optional #137

improvements based on SouzaEM's comments
498354a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 20, 2024 in 1s

84.95% (+0.61%) compared to 437cf28

View this Pull Request on Codecov

84.95% (+0.61%) compared to 437cf28

Details

Codecov Report

Attention: Patch coverage is 50.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 84.95%. Comparing base (437cf28) to head (498354a).

Files with missing lines Patch % Lines
spyro/meshing/meshing_functions.py 60.00% 4 Missing ⚠️
spyro/solvers/acoustic_wave.py 42.85% 4 Missing ⚠️
spyro/tools/velocity_smoother.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
+ Coverage   84.34%   84.95%   +0.61%     
==========================================
  Files          59       59              
  Lines        3935     3949      +14     
==========================================
+ Hits         3319     3355      +36     
+ Misses        616      594      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features: