Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assets using ExternalFile should use a File's OutName over Name when emitting includes for the external file #308

Open
Thar0 opened this issue Dec 14, 2023 · 1 comment

Comments

@Thar0
Copy link
Contributor

Thar0 commented Dec 14, 2023

Consider an xml using OutName for files, such as a split gameplay_keep:

<Root>
    <ExternalFile XmlPath="misc/link_animetion.xml" OutPath="assets/misc/link_animetion/"/>

    <File Name="gameplay_keep" Segment="4" OutName="hilite_textures.c" RangeStart="0x0" RangeEnd="0x400">
        <Texture Name="gHilite1Tex" OutName="hilite_1" Format="rgba16" Width="16" Height="16" Offset="0x0"/>
        <Texture Name="gHilite2Tex" OutName="hilite_2" Format="rgba16" Width="16" Height="16" Offset="0x200"/>
    </File>

    ...

    <File Name="gameplay_keep" Segment="4" OutName="gameplay_keep_0x32090.c" RangeStart="0x32090" RangeEnd="0x33090">
        <Texture Name="gEffUnknown9Tex" OutName="eff_unknown_9" Format="i8" Width="32" Height="32" Offset="0x32090"/>
        <Texture Name="gEffUnknown10Tex" OutName="eff_unknown_10" Format="i8" Width="32" Height="32" Offset="0x32490"/>
        <Texture Name="gEffUnknown11Tex" OutName="eff_unknown_11" Format="i8" Width="32" Height="32" Offset="0x32890"/>
        <Texture Name="gEffUnknown12Tex" OutName="eff_unknown_12" Format="i8" Width="32" Height="32" Offset="0x32C90"/>
    </File>

    ...

Headers are created such as assets/objects/gameplay_keep/hilite_textures.h, assets/objects/gameplay_keep/gameplay_keep_0x32090.h, etc.

Other assets that refer to gameplay_keep using ExternalFile, e.g. object_demo_6k.xml, will emit the include
#include "assets/objects/gameplay_keep/gameplay_keep.h"
This header however may not exist if all <File> elements in gameplay_keep have been given OutNames, or the header may exist but is not guaranteed to contain the relevant symbol(s) referenced by the other asset file.

Assets using ExternalFile should use the OutName of the file(s) that contains the symbol(s) referenced. For example object_demo_6k references gEffUnknown10Tex so should include assets/objects/gameplay_keep/gameplay_keep_0x32090.h as that is the file that contains that symbol. This should be done for all symbols referenced.

@NEstelami
Copy link
Owner

Thank you for making this issue known. Unfortunately I cannot in good faith make the requested fixes.

For the past year I have been the target of harassment by a member of ZeldaRET. I have tried to resolve the matter with Fig for the past 10 months. He said we would talk and asked that I wait for a short time, which I patiently did. We never talked. Instead, he chose to ghost me for those entire 10 months. He continues to ignore my messages, in spite of the continued harassment I am receiving. As of today he has blocked me.

I would have preferred to resolve this matter privately, but after nearly a year of being blown off it seems that will not be possible. So I want to to be transparent about my reasons for not supporting the needs of ZRET any longer. My intent is not to start drama, just be transparent.

At this point I think it is fair to say that despite what I have dedicated to this group I am neither valued nor respected. For that reason and more I will not be investing any more of my limited free time supporting a group that does not support me.

I wish you all the best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants