Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update i/o routines for new surface coldstart file. #698

Merged
merged 28 commits into from
Feb 7, 2024
Merged

Update i/o routines for new surface coldstart file. #698

merged 28 commits into from
Feb 7, 2024

Conversation

GeorgeGayno-NOAA
Copy link
Contributor

@GeorgeGayno-NOAA GeorgeGayno-NOAA commented Sep 14, 2023 •
edited by BrianCurtis-NOAA
Loading

Description

The UFS_UTILS chgres_cube program is being updated to process fractional grids. The surface coldstart file generated by the new chgres_cube will contain new records. Update the FV3 routines to read either the new surface coldstart format or the original format. The new coldstart files (named version 2) will contain the following global attribute:

// global attributes:
                :file_version = "V2" ;

The model i/o routine will check for this attribute and act accordingly.

Since the updates to the model i/o routine are backwards compatible, regression test results should not change.

Issue(s) addressed

Associated PR's

Testing

The regression tests were run on Hera using the branch at bbc5bf8 and passed. The regression test log is here: https://github.com/GeorgeGayno-NOAA/ufs-weather-model/blob/9bfffc16568b5d2039c956642d601b41dbad9190/tests/logs/RegressionTests_hera.log

Dependencies

The updates to chgres_cube are being tracked here: ufs-community/UFS_UTILS#123

This PR will also include one or two new regression tests. See below for details.

@GeorgeGayno-NOAA
Update read of surface restart file to make the surface-specific
fc9c8dc 
records mandatory and the 'composite' records optional.
Compute the 'composite' records from the surface-specific
records.

Fixes NOAA-EMC#670.
@GeorgeGayno-NOAA
Update some comments.
9da8ce4 
Fixes NOAA-EMC#670.
@GeorgeGayno-NOAA
Merge branch 'develop' into sfc_coldstart
ede603f 
Fixes NOAA-EMC#670.
@GeorgeGayno-NOAA
Point to correct ccpp/physics and upp tags.
bfd2417 
Fixes NOAA-EMC#670.
@GeorgeGayno-NOAA
Fix syntax error.
99cc1ce 
Fixes NOAA-EMC#670.
@GeorgeGayno-NOAA
Merge branch 'develop' into sfc_coldstart
7ffdcbe 
Fixes NOAA-EMC#670.
@GeorgeGayno-NOAA
Update logic to read either an 'old' style surface coldstart
aba1b3c 
file or a new surface file from the new chgres_cube. The
new files will have a global attribute saying this is a
version 2 file.

Fixes NOAA-EMC#670.
@GeorgeGayno-NOAA GeorgeGayno-NOAA changed the title Sfc coldstart Update i/o routines for new surface coldstart file. Sep 14, 2023
@GeorgeGayno-NOAA
Copy link
Contributor Author

GeorgeGayno-NOAA commented Sep 15, 2023 •
edited
Loading

Request one new regression test that is based on the 'control_c48_intel' test. That test is ATM only and uses a non-fractional grid.

The new test's coldstart files used the same input GFS data to chgres (located here /scratch1/NCEPDEV/stmp2/Jun.Wang/gdas/2021032206) and the same model configuration files.

The 'oro' and other fixed files used by the new test were: /scratch1/NCEPDEV/global/glopara/fix/orog/20220805/C48.mx500.

The coldstart files for the new test are here: /scratch1/NCEPDEV/da/George.Gayno/ufs_utils.git/chgres_cube.fractional/RT/FV3_input_data48/INPUT_L127.v2.sfc

@GeorgeGayno-NOAA GeorgeGayno-NOAA mentioned this pull request Nov 3, 2023
Closed
This was referenced Nov 20, 2023
Merged
Merged
@GeorgeGayno-NOAA
Copy link
Contributor Author

Request one new regression test that is based on the 'control_c48_intel' test. That test is ATM only and uses a non-fractional grid.

The new test's coldstart files used the same input GFS data to chgres (located here /scratch1/NCEPDEV/stmp2/Jun.Wang/gdas/2021032206) and the same model configuration files.

The 'oro' and other fixed files used by the new test were: /scratch1/NCEPDEV/global/glopara/fix/orog/20220805/C48.mx500.

The coldstart files for the new test are here: /scratch1/NCEPDEV/da/George.Gayno/ufs_utils.git/chgres_cube.fractional/RT/FV3_input_data48/INPUT_L127.v2.sfc

For details on the new regression test data, see ufs-community/ufs-weather-model#2005

@GeorgeGayno-NOAA GeorgeGayno-NOAA marked this pull request as ready for review December 27, 2023 21:06
@GeorgeGayno-NOAA
Copy link
Contributor Author

@jkbk2004 - This is related to ufs-community/ufs-weather-model#2005. I do not have permissions to assign a reviewer to this PR.

@zach1221
Copy link
Collaborator

zach1221 commented Feb 7, 2024

@jkbk2004 we have approvals here, and testing is complete on 2005. Can you please merge this PR?

@jkbk2004 jkbk2004 merged commit b8f7b0f into NOAA-EMC:develop Feb 7, 2024
2 checks passed
@grantfirl grantfirl mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrianCurtis-NOAA BrianCurtis-NOAA BrianCurtis-NOAA approved these changes

@DusanJovic-NOAA DusanJovic-NOAA DusanJovic-NOAA approved these changes

@jkbk2004 jkbk2004 Awaiting requested review from jkbk2004

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update fv3atm_sfc_io.F90 to read new surface coldstart files
5 participants
@GeorgeGayno-NOAA @zach1221 @DusanJovic-NOAA @BrianCurtis-NOAA @jkbk2004