issue #292 fix overflow for complex-3 packing #298
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #292
Grib2 uses packed (positive) integers, and the wgrib2 routines limit the length of integers to 25 bits. This is not a limitation for floating point numbers because the IEEE float format is limits the size of the mantissa to 24 bits (single precision). For most meteorological you only need 12-16 bits of precision. However, for precipitation people like high precision and routinely set the precision to 24 bits. The problem occurs with complex packing 3 which stores the deltas of the deltas. With an uncommon pattern of precip, the size of the scaled integers can increase 4 fold (+2 bits) which causes the scaled integers to exceed the 25 bit limit. This fix (1) updates the web documentation and (2) updates complex_pk.c which will not reduce the requested precision if necessary. Test for the fix was added.