Allow no components in add_components #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old behavior was causing a problem for user code that passed a dynamically-built list of components to system.add_components. Requiring that code to check for an empty list was onerous, and we can safely let it go through with no error.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
==========================================
- Coverage 95.43% 95.43% -0.01%
==========================================
Files 33 33
Lines 2741 2739 -2
==========================================
- Hits 2616 2614 -2
Misses 125 125 ☔ View full report in Codecov by Sentry. |
pesap
approved these changes
Oct 23, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 24, 2024
Allow no components in add_components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old behavior was causing a problem for user code that passed a dynamically-built list of components to system.add_components. Requiring that code to check for an empty list was onerous, and we can safely let it go through with no error.