-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some command tests fail with Highline 1.6.9 under JRuby #17
Comments
Failures continue on HighLine 1.6.15 with JRuby 1.7.3. There are actually 5 failures with this combination. All of them seem to be related to stdin/stdout/stderr overrides in the test suite. |
It is related to the use of JLine in HighLine 1.6.9 and later. There are two problems:
The second one means that this does affect the CLI in real life (it wants to output prompts to standard error, while the hard-coded stream in the JLine integration is standard out), so the solution of locking to a pre-1.6.9 version of HighLine until HighLine is fixed is correct. |
Closed by #23. |
Actually, even with the changes outlined in my comments above, there are still several test failures with later highline versions on JRuby. |
Three of the CLI specs fail using HighLine 1.6.9 under JRuby 1.6.5. There's a note about switching to JLine in the HL changelog; that might be the culprit. I'm not sure if the issue actually affects the CLI or just the tests.
The text was updated successfully, but these errors were encountered: