Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile inconsistent with Documentation & CUDA Version hardcoded #169

Open
danielphilipp opened this issue Dec 4, 2024 · 0 comments
Open

Comments

@danielphilipp
Copy link

danielphilipp commented Dec 4, 2024

Hi NVIDIA Team,

we built the vGPU driver container with this repo some months ago and it worked fine when following the official vGPU driver container build documentation (Docs)

I pulled the latest repo this morning and build the container for a new driver version and it failed. I noticed two changes to the Dockerfile (Ubuntu 22.04, Dockerfile):

  • In line 1 and line 35: CUDA Versions are hardcoded to 12.6.3 and so the CUDA_VERSION build argument which is used in the documentation is not used in the Dockerfile. I think it should be possible to set the CUDA version as mentioned in the docs.
  • In line 4: The GOLANG_VERSION build arg is required otherwise the download in line 22 failes because the .tar.gz filename is wrong (empty variable). In previous versions the GOLANG_VERSION was hardcoded as environment variable in the Dockerfile. The docs do not mention that you need to set GOLANG_VERSION as build arg.

I would recommend to make the CUDA_VERSION a build arg parameter and adapt the documentation that the GOLANG_VERSION is now also required as a build arg (or hardcode it again in the Dockerfile).

Thank you for your work!

Regards,
Daniel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant