Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan-tutorial.com is updated. #13

Open
Trunkvv opened this issue Nov 21, 2022 · 7 comments
Open

Vulkan-tutorial.com is updated. #13

Trunkvv opened this issue Nov 21, 2022 · 7 comments

Comments

@Trunkvv
Copy link

Trunkvv commented Nov 21, 2022

Suggestion: Alexander Overvoorde updated his tutorial on vulkan-tutorial.com. Perhaps this excellent port to Java can be updated as well?

@Trunkvv Trunkvv changed the title Suggestion: Alexander Overvoorde updated his tutorial on vulkan-tutorial.com. Perhaps this excellent port to Java can be updated as well? Vulkan-tutorial is updated. Nov 21, 2022
@Trunkvv Trunkvv changed the title Vulkan-tutorial is updated. Vulkan-tutorial.com is updated. Nov 21, 2022
@Naitsirc98
Copy link
Owner

I'm busy with work and other projects right now, but I will check vulkantutorial.com and update this repository in my spare time.

I will close this issue when I finish the update. I'll try to start it ASAP.

Thank you!

@Trunkvv
Copy link
Author

Trunkvv commented Nov 21, 2022

Thx for your reply.
I have had a look at the differences and my experience is currently too little to change it myself and offer you a pull request.
No rush. You your spare time wisely.

@Trunkvv
Copy link
Author

Trunkvv commented Nov 26, 2022

Hi Cristian,
A lot of the porting stuff that's in there with off heap memory and working with pointers in Java, is new to me. So to understand it, you need to work with it. So I've copied this repository into a new local project and tried to incorporate the latest updates on vulkantutorial.com. Took some time, but was a success. I'm fairly new to Git, but do you want me to prepare a PR for this issue and #14?

@Naitsirc98
Copy link
Owner

Nice! I'm glad you'd been able to understand the core concepts and even incorporate the last changes to the original tutorial yourself!

I'm planning to rewrite this port entirely, to refactor and improve the Java code while I'm at it. It will took some time but I hope the code will improve a lot afterwards.

Thank you ;)

@Trunkvv
Copy link
Author

Trunkvv commented Nov 27, 2022

Okay, so I'll guess it's a No for a PR from me. No problem at all.

I've already worked on the C++ code of vulkan-tutorial.com beefore. And managed to add some extra to like push constants, dynamic (indexed offsets) uniform buffers so it can handle rendering with multiple (layered) textures in a model and render multiple models/meshes. I'dd like to do this in Java as well.

I'm thinking about publishing a public fork of your vulkan-tutorial.com port to Java and add some extra features on top it. Are you okay with this?

@Naitsirc98
Copy link
Owner

Hi @Trunkvv

Of course! This repository is the "official" port to Java, so I have to stick to the contents of the original tutorial. But feel free to modify it and add more features in your own fork.

In fact, you must do it if you really want to learn Vulkan. The vulkan-tutorial is just the first step :D

@Trunkvv
Copy link
Author

Trunkvv commented Nov 29, 2022

Okay, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants