Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only accept txs once synced #7788

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Only accept txs once synced #7788

wants to merge 10 commits into from

Conversation

benaadams
Copy link
Member

Is a lot of additional work on processing blocks and adding tx in the txpool that is completely irrelevant until synced. Skip this extra work.

Effects all types of sync (snap, full, archive etc)

Changes

  • Skip trying to add tx to txpool if not yet synced
  • Don't process block events in txpool if not yet synced

Types of changes

What types of changes does your code introduce?

  • Optimization

Testing

Requires testing

  • Yes

If yes, did you write tests?

  • Yes

@benaadams
Copy link
Member Author

Accept local tx

Copy link
Contributor

@marcindsobczak marcindsobczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a great change, but I would definitely not return AcceptTxResult.AlreadyKnown when syncing as it can be misleading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants