Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename attribute selection to attribute lookup #8197

Open
roberth opened this issue Apr 10, 2023 · 2 comments
Open

Rename attribute selection to attribute lookup #8197

roberth opened this issue Apr 10, 2023 · 2 comments
Assignees
Labels
documentation language The Nix expression language; parser, interpreter, primops, evaluation, etc

Comments

@roberth
Copy link
Member

roberth commented Apr 10, 2023

Is your feature request related to a problem? Please describe.

ExprSelect is a.b, and a.b or c (for metavariables a, b, c)

"Lookup" is less ambiguous than "select", and a more readily available term.

Describe the solution you'd like

  • Change all occurrences of attribute selection to attribute lookup in the docs
  • s/ExprSelect/ExprAttrLookup

Describe alternatives you've considered

"Get", which is ugly in natural language. How would you say "attribute lookup": "attribute getting"? You'd need more words to make it not suck.

Additional context

Priorities

Add 👍 to issues you find important.

@roberth roberth added documentation language The Nix expression language; parser, interpreter, primops, evaluation, etc labels Apr 10, 2023
@roberth roberth changed the title Rename attribute _selection_ to attribute _lookup_ Rename attribute selection to attribute lookup Apr 10, 2023
@roberth roberth added this to Nix team Apr 10, 2023
@thufschmitt thufschmitt moved this to 🏁 Assigned in Nix team May 12, 2023
@fricklerhandwerk
Copy link
Contributor

fricklerhandwerk commented May 15, 2023

Triaged in Nix team meeting 2023-05-12:

  • @regnat: no strong opinion
  • @eriscon2314: could delegate to the docs team
  • @fricklerhandwerk will think about it, but low priority
    • may be something for @NixOS/documentation-team to discuss briefly
  • @Ericson2314: should we rename attribute to field?
  • @edolstra: should probably rename attribute set to dictionary, since it's not a set
    • but large scale renames are problematic because all the documentation will refer to the old name

@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-05-12-nix-team-meeting-minutes-54/28197/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation language The Nix expression language; parser, interpreter, primops, evaluation, etc
Projects
Status: No status
Status: 🏁 Review
Development

No branches or pull requests

3 participants