add parameter check to random_uniform_initializer (#3316)

Former-commit-id: 29e6c25
Oneflow-Inc · Jul 28, 2020 · ea1e638 · ea1e638
1 parent ed432d6
commit ea1e638
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/oneflow/python/ops/initializer_util.py b/oneflow/python/ops/initializer_util.py
@@ -82,6 +82,7 @@ def random_uniform_initializer(
     Returns:
         An InitializerConf object.
     """
+    assert minval <= maxval
     initializer = op_conf_util.InitializerConf()
     if dtype in [dtype_util.float, dtype_util.double]:
         setattr(initializer.random_uniform_conf, "min", float(minval))

diff --git a/oneflow/python/test/ops/test_slice_v2.py b/oneflow/python/test/ops/test_slice_v2.py
@@ -195,7 +195,7 @@ def slice(input_blob: oft.Numpy.Placeholder(shape=(2, 5, 4), dtype=flow.float)):
         x = flow.get_variable(
             shape=(2, 5, 4),
             dtype=flow.float,
-            initializer=flow.random_uniform_initializer(0, 1),
+            initializer=flow.random_uniform_initializer(0, 2),
             name="variable",
         )
         x = flow.identity(x)