Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation unclear: compression #30295

Open
bmarwell opened this issue Nov 26, 2024 · 1 comment
Open

Documentation unclear: compression #30295

bmarwell opened this issue Nov 26, 2024 · 1 comment

Comments

@bmarwell
Copy link
Contributor

bmarwell commented Nov 26, 2024

Hi,

I have a few issues with the compression documentation.

It was outlined here: https://openliberty.io/blog/2020/04/22/http-response-compression.html
The actual docs I am referring to: https://openliberty.io/docs/latest/reference/config/compression.html

Here are some enhancements I would like to suggest:

Compression algorithm

currently, we have support for:

  • gzip,
  • x-gzip,
  • deflate,
  • zlib,
  • identity

Update wish / recommendation

  • Please explain each item (I thought deflate is the algorithm used in gz?).
  • Mention identity equals no-compression
  • Mention zlib is hardly supported by browsers
  • Mention zlib has AIX hardware support (has it?)

Future perspective: brotli, lz4 and zstd

Modern browsers will send: Accept-Encoding: gzip, deflate, br, zstd (Firefox, Edge, others).

Please document the small overlap and maybe reference wishlist issues / github RFE issues for br (brotli) and zstd (and maybe lz4).

serverPreferredAlgorithm

This is an attribute, interestingly. Make that information stand out, maybe add an example. Usually server.xml uses tags only, so this is somewhat unexpected.

Luckily, <config onError="fail" /> will make the startup fail.

types

Invalid tags won't fail the start

<config onError="fail" /> will NOT make the startup fail if you accidentally use <type> instead of <types>.
Please mention this explicitly (and why it DOES fail for <serverPreferredAlgorithm>, see above section).

Give examples of configurations

Give an example snipped for the default configuration

combination of no prefix, + and -

What happens if you combine those?

<compression>
  <types>text/plain</types>
  <types>+text/*</types>
  <types>-text/xml</types>
</compression>

What would be the outcome? What takes precedence? What about other combinations?

minGzipSize

This option is not documented


Thanks!

@bmarwell
Copy link
Contributor Author

Oh, and by the way, could a user extension extend the list of algorithms?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants