Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming convention for ports needs to be improved #9

Closed
dietmarw opened this issue Nov 20, 2019 · 3 comments
Closed

Naming convention for ports needs to be improved #9

dietmarw opened this issue Nov 20, 2019 · 3 comments
Assignees
@dietmarw
Labels
enhancement New feature or request
Milestone
v2.0.0

Comments

@dietmarw
Copy link
Collaborator

The documentation and parameters always refer to inlet and outlet but also to D_1 and D_2. In addition the connectors are named p and n which adds even more confusion.
The naming should be cleaned up and should use index i and o instead, throughout the library.
@dietmarw dietmarw added the enhancement New feature or request label Nov 20, 2019
@dietmarw dietmarw self-assigned this Nov 20, 2019
@dietmarw dietmarw added this to the v2.0.0 milestone Nov 20, 2019
dietmarw added a commit that referenced this issue Nov 20, 2019
@dietmarw
Refs #9: Renaming the ports from p,n to i,o
b08e3fa
dietmarw added a commit that referenced this issue Nov 20, 2019
@dietmarw
Ref #9: Finished renaming the ports
bc6919f 
None of the experimental test models in `Tests` will work since they were not updated. Not much point in wasting time to do that now. Rather look at those models and fix them when needed.
@dietmarw
Copy link
Collaborator Author

Fixed in b08e3fa and bc6919f

@dietmarw
Copy link
Collaborator Author

Documentation still needs to be updated. I.e., the images.

@dietmarw dietmarw reopened this Nov 20, 2019
dietmarw added a commit that referenced this issue Nov 20, 2019
@dietmarw
Ref #9 Update the User's Guide.
36498c7
@dietmarw dietmarw mentioned this issue Sep 7, 2022
Open
@dietmarw
Copy link
Collaborator Author

dietmarw commented Sep 7, 2022 •
edited
Loading

The User's Guide update has been postponed to a later release. See #39

@dietmarw dietmarw closed this as completed Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dietmarw dietmarw

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
1 participant
@dietmarw