Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a valve model #59

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add a valve model #59

wants to merge 5 commits into from

Commits on Jun 28, 2024

  1. Splits the Turbine into a BaseValve and Turbine model 

    Fixes #75

At the same time a simple valve component is introduced which is based on the `BaseValve` model just like the turbine model is now also based on this.
An example model was also added.
    @dietmarw
    dietmarw committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    288036b View commit details
    Browse the repository at this point in the history

  2. Simplify the example parameters.

    @dietmarw
    dietmarw committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    daae129 View commit details
    Browse the repository at this point in the history

  3. Rename the examples to reflect the turbine usage 

    Since we now have a `SimpleValve` model a it seems better to emphasise when a turbine is part of the example.
    @dietmarw
    dietmarw committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    c213b09 View commit details
    Browse the repository at this point in the history

  4. TurbineContacts should not extend from ContactPort 

    The BaseValve model takes care of this.
    @dietmarw
    dietmarw committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    633bb67 View commit details
    Browse the repository at this point in the history

  5. Syntax clean up.

    @dietmarw
    dietmarw committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    6d376e4 View commit details
    Browse the repository at this point in the history