Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harmonize interface of methods and create unified interface #11

Merged
merged 22 commits into from
Jun 3, 2024
Merged

Harmonize interface of methods and create unified interface #11

merged 22 commits into from
Jun 3, 2024

Conversation

MaxBlesch
Copy link
Member

No description provided.

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@codecov Codecov
Copy link

codecov bot commented Jun 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6cfdb2c) to head (082836e).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main       #11   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         5    +1     
  Lines          433       440    +7     
=========================================
+ Hits           433       440    +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MaxBlesch MaxBlesch requested a review from segsell June 2, 2024 09:51
segsell
segsell reviewed Jun 2, 2024
View reviewed changes
Copy link
Member

@segsell segsell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR! I really like the handy jit implementations. See some minor comments below.

src/upper_envelope/fues_numba/fues_numba.py Outdated Show resolved Hide resolved
src/upper_envelope/fues_numba/fues_numba.py Outdated Show resolved Hide resolved
src/upper_envelope/fues_jax/fues_jax.py Outdated Show resolved Hide resolved
src/upper_envelope/fues_numba/fues_numba.py Outdated Show resolved Hide resolved
segsell
segsell approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@segsell segsell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Thank you 🎉

@MaxBlesch MaxBlesch merged commit 7ce4132 into main Jun 3, 2024
3 checks passed
MaxBlesch added a commit that referenced this pull request Jun 3, 2024
@MaxBlesch
Revert "Harmonize interface of methods(#11)"
cb6bd3c 
This reverts commit 7ce4132.
@MaxBlesch MaxBlesch deleted the interface branch June 3, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@segsell segsell segsell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxBlesch @segsell