configs: correct MaxHartIdBits #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivyfeather
approved these changes
Apr 2, 2024
Currently, many different lengths of HartId in Xiangshan, making it hard to configure it to scale more than 16 cores since we have set 4bits somewhere. This commit corrects MaxHartIdBits in config and uses MaxHartIDBits where it needs to get this solved. Signed-off-by: Yangyu Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, many different lengths of HartId in Xiangshan, making it hard to configure it to scale more than 16 cores since we have set 4bits somewhere. This commit corrects MaxHartIdBits in config and uses MaxHartIDBits where it needs to get this solved.