From 9fb0d434e72ca8685eb7fabb6f9381c8f9003085 Mon Sep 17 00:00:00 2001 From: Max Marrone Date: Wed, 4 Dec 2024 10:31:48 -0500 Subject: [PATCH] More comment tweaking. --- .../protocol_engine/state/test_addressable_area_store_old.py | 2 +- .../protocol_engine/state/test_addressable_area_view_old.py | 2 +- .../opentrons/protocol_engine/state/test_command_store_old.py | 3 ++- .../opentrons/protocol_engine/state/test_command_view_old.py | 3 ++- .../opentrons/protocol_engine/state/test_labware_store_old.py | 2 +- .../opentrons/protocol_engine/state/test_labware_view_old.py | 2 +- .../protocol_engine/state/test_liquid_class_store_old.py | 2 +- .../protocol_engine/state/test_liquid_class_view_old.py | 2 +- .../opentrons/protocol_engine/state/test_liquid_store_old.py | 3 ++- .../opentrons/protocol_engine/state/test_liquid_view_old.py | 3 ++- .../opentrons/protocol_engine/state/test_module_store_old.py | 3 ++- .../opentrons/protocol_engine/state/test_module_view_old.py | 3 ++- .../opentrons/protocol_engine/state/test_pipette_store_old.py | 3 ++- .../opentrons/protocol_engine/state/test_pipette_view_old.py | 3 ++- .../opentrons/protocol_engine/state/test_well_store_old.py | 3 ++- .../opentrons/protocol_engine/state/test_well_view_old.py | 3 ++- 16 files changed, 26 insertions(+), 16 deletions(-) diff --git a/api/tests/opentrons/protocol_engine/state/test_addressable_area_store_old.py b/api/tests/opentrons/protocol_engine/state/test_addressable_area_store_old.py index 1fc6da5c646..b9e3e8f4e78 100644 --- a/api/tests/opentrons/protocol_engine/state/test_addressable_area_store_old.py +++ b/api/tests/opentrons/protocol_engine/state/test_addressable_area_store_old.py @@ -2,7 +2,7 @@ DEPRECATED: Testing AddressableAreaStore independently of AddressableAreaView is no longer helpful. Try to add new tests to test_addressable_area_state.py, where they can be -tested together. +tested together, treating AddressableAreaState as a private implementation detail. """ import pytest diff --git a/api/tests/opentrons/protocol_engine/state/test_addressable_area_view_old.py b/api/tests/opentrons/protocol_engine/state/test_addressable_area_view_old.py index c0136a65abc..5aa157c59db 100644 --- a/api/tests/opentrons/protocol_engine/state/test_addressable_area_view_old.py +++ b/api/tests/opentrons/protocol_engine/state/test_addressable_area_view_old.py @@ -2,7 +2,7 @@ DEPRECATED: Testing AddressableAreaView independently of AddressableAreaStore is no longer helpful. Try to add new tests to test_addressable_area_state.py, where they can be -tested together. +tested together, treating AddressableAreaState as a private implementation detail. """ import inspect diff --git a/api/tests/opentrons/protocol_engine/state/test_command_store_old.py b/api/tests/opentrons/protocol_engine/state/test_command_store_old.py index f4b934834e6..a9022803bcf 100644 --- a/api/tests/opentrons/protocol_engine/state/test_command_store_old.py +++ b/api/tests/opentrons/protocol_engine/state/test_command_store_old.py @@ -1,7 +1,8 @@ """Tests for CommandStore. DEPRECATED: Testing CommandStore independently of CommandView is no longer helpful. -Try to add new tests to test_command_state.py, where they can be tested together. +Try to add new tests to test_command_state.py, where they can be tested together, +treating CommandState as a private implementation detail. """ diff --git a/api/tests/opentrons/protocol_engine/state/test_command_view_old.py b/api/tests/opentrons/protocol_engine/state/test_command_view_old.py index 8f3b1effb98..de242d83f51 100644 --- a/api/tests/opentrons/protocol_engine/state/test_command_view_old.py +++ b/api/tests/opentrons/protocol_engine/state/test_command_view_old.py @@ -1,7 +1,8 @@ """Tests for CommandView. DEPRECATED: Testing CommandView independently of CommandStore is no longer helpful. -Try to add new tests to test_command_state.py, where they can be tested together. +Try to add new tests to test_command_state.py, where they can be tested together, +treating CommandState as a private implementation detail. """ diff --git a/api/tests/opentrons/protocol_engine/state/test_labware_store_old.py b/api/tests/opentrons/protocol_engine/state/test_labware_store_old.py index 3e3e82f5d3a..3b539df58e3 100644 --- a/api/tests/opentrons/protocol_engine/state/test_labware_store_old.py +++ b/api/tests/opentrons/protocol_engine/state/test_labware_store_old.py @@ -2,7 +2,7 @@ DEPRECATED: Testing LabwareStore independently of LabwareView is no longer helpful. Try to add new tests to test_labware_state.py, where they can be -tested together. +tested together, treating LabwareState as a private implementation detail. """ from typing import Optional from opentrons.protocol_engine.state import update_types diff --git a/api/tests/opentrons/protocol_engine/state/test_labware_view_old.py b/api/tests/opentrons/protocol_engine/state/test_labware_view_old.py index 4ed8a99f9c9..0b6886040c6 100644 --- a/api/tests/opentrons/protocol_engine/state/test_labware_view_old.py +++ b/api/tests/opentrons/protocol_engine/state/test_labware_view_old.py @@ -2,7 +2,7 @@ DEPRECATED: Testing LabwareView independently of LabwareStore is no longer helpful. Try to add new tests to test_labware_state.py, where they can be -tested together. +tested together, treating LabwareState as a private implementation detail. """ import pytest from datetime import datetime diff --git a/api/tests/opentrons/protocol_engine/state/test_liquid_class_store_old.py b/api/tests/opentrons/protocol_engine/state/test_liquid_class_store_old.py index 5f627739f94..57397ec61cb 100644 --- a/api/tests/opentrons/protocol_engine/state/test_liquid_class_store_old.py +++ b/api/tests/opentrons/protocol_engine/state/test_liquid_class_store_old.py @@ -2,7 +2,7 @@ DEPRECATED: Testing LiquidClassStore independently of LiquidClassView is no longer helpful. Try to add new tests to test_liquid_class_state.py, where they can be -tested together. +tested together, treating LiquidClassState as a private implementation detail. """ import pytest diff --git a/api/tests/opentrons/protocol_engine/state/test_liquid_class_view_old.py b/api/tests/opentrons/protocol_engine/state/test_liquid_class_view_old.py index e68ad325935..f28438b3756 100644 --- a/api/tests/opentrons/protocol_engine/state/test_liquid_class_view_old.py +++ b/api/tests/opentrons/protocol_engine/state/test_liquid_class_view_old.py @@ -2,7 +2,7 @@ DEPRECATED: Testing LiquidClassView independently of LiquidClassStore is no longer helpful. Try to add new tests to test_liquid_class_state.py, where they can be -tested together. +tested together, treating LiquidClassState as a private implementation detail. """ import pytest diff --git a/api/tests/opentrons/protocol_engine/state/test_liquid_store_old.py b/api/tests/opentrons/protocol_engine/state/test_liquid_store_old.py index f8bd7693a7b..18417fe7570 100644 --- a/api/tests/opentrons/protocol_engine/state/test_liquid_store_old.py +++ b/api/tests/opentrons/protocol_engine/state/test_liquid_store_old.py @@ -1,7 +1,8 @@ """Liquid state store tests. DEPRECATED: Testing LiquidStore independently of LiquidView is no longer helpful. -Try to add new tests to test_liquid_state.py, where they can be tested together. +Try to add new tests to test_liquid_state.py, where they can be tested together, +treating LiquidState as a private implementation detail. """ import pytest from opentrons.protocol_engine.state.liquids import LiquidStore diff --git a/api/tests/opentrons/protocol_engine/state/test_liquid_view_old.py b/api/tests/opentrons/protocol_engine/state/test_liquid_view_old.py index 0e79ee45eb0..92a9a2bd667 100644 --- a/api/tests/opentrons/protocol_engine/state/test_liquid_view_old.py +++ b/api/tests/opentrons/protocol_engine/state/test_liquid_view_old.py @@ -1,7 +1,8 @@ """Liquid view tests. DEPRECATED: Testing LiquidView independently of LiquidStore is no longer helpful. -Try to add new tests to test_liquid_state.py, where they can be tested together. +Try to add new tests to test_liquid_state.py, where they can be tested together, +treating LiquidState as a private implementation detail. """ import pytest diff --git a/api/tests/opentrons/protocol_engine/state/test_module_store_old.py b/api/tests/opentrons/protocol_engine/state/test_module_store_old.py index 4fe7d2791c1..e4ab52ebaf8 100644 --- a/api/tests/opentrons/protocol_engine/state/test_module_store_old.py +++ b/api/tests/opentrons/protocol_engine/state/test_module_store_old.py @@ -1,7 +1,8 @@ """Module state store tests. DEPRECATED: Testing ModuleStore independently of ModuleView is no longer helpful. -Try to add new tests to test_module_state.py, where they can be tested together. +Try to add new tests to test_module_state.py, where they can be tested together, +treating ModuleState as a private implementation detail. """ from typing import List, Set, cast, Dict, Optional diff --git a/api/tests/opentrons/protocol_engine/state/test_module_view_old.py b/api/tests/opentrons/protocol_engine/state/test_module_view_old.py index a904b4d5916..3902eedc76f 100644 --- a/api/tests/opentrons/protocol_engine/state/test_module_view_old.py +++ b/api/tests/opentrons/protocol_engine/state/test_module_view_old.py @@ -1,7 +1,8 @@ """Tests for module state accessors in the protocol engine state store. DEPRECATED: Testing ModuleView independently of ModuleView is no longer helpful. -Try to add new tests to test_module_state.py, where they can be tested together. +Try to add new tests to test_module_state.py, where they can be tested together, +treating ModuleState as a private implementation detail. """ import pytest from math import isclose diff --git a/api/tests/opentrons/protocol_engine/state/test_pipette_store_old.py b/api/tests/opentrons/protocol_engine/state/test_pipette_store_old.py index d38af50f772..b88844bb53d 100644 --- a/api/tests/opentrons/protocol_engine/state/test_pipette_store_old.py +++ b/api/tests/opentrons/protocol_engine/state/test_pipette_store_old.py @@ -1,7 +1,8 @@ """Tests for pipette state changes in the protocol_engine state store. DEPRECATED: Testing PipetteStore independently of PipetteView is no longer helpful. -Try to add new tests to test_pipette_state.py, where they can be tested together. +Try to add new tests to test_pipette_state.py, where they can be tested together, +treating PipetteState as a private implementation detail. """ import pytest diff --git a/api/tests/opentrons/protocol_engine/state/test_pipette_view_old.py b/api/tests/opentrons/protocol_engine/state/test_pipette_view_old.py index 2fa5b161cf2..ce07e5fda8e 100644 --- a/api/tests/opentrons/protocol_engine/state/test_pipette_view_old.py +++ b/api/tests/opentrons/protocol_engine/state/test_pipette_view_old.py @@ -1,7 +1,8 @@ """Tests for pipette state accessors in the protocol_engine state store. DEPRECATED: Testing PipetteView independently of PipetteStore is no longer helpful. -Try to add new tests to test_pipette_state.py, where they can be tested together. +Try to add new tests to test_pipette_state.py, where they can be tested together, +treating PipetteState as a private implementation detail. """ from collections import OrderedDict diff --git a/api/tests/opentrons/protocol_engine/state/test_well_store_old.py b/api/tests/opentrons/protocol_engine/state/test_well_store_old.py index 2acadae000f..51142afd9da 100644 --- a/api/tests/opentrons/protocol_engine/state/test_well_store_old.py +++ b/api/tests/opentrons/protocol_engine/state/test_well_store_old.py @@ -1,7 +1,8 @@ """Well state store tests. DEPRECATED: Testing WellStore independently of WellView is no longer helpful. -Try to add new tests to well_state.py, where they can be tested together. +Try to add new tests to well_state.py, where they can be tested together, +treating WellState as a private implementation detail. """ import pytest diff --git a/api/tests/opentrons/protocol_engine/state/test_well_view_old.py b/api/tests/opentrons/protocol_engine/state/test_well_view_old.py index 7b213f63bcf..9ced4db9df0 100644 --- a/api/tests/opentrons/protocol_engine/state/test_well_view_old.py +++ b/api/tests/opentrons/protocol_engine/state/test_well_view_old.py @@ -1,7 +1,8 @@ """Well view tests. DEPRECATED: Testing WellView independently of WellStore is no longer helpful. -Try to add new tests to test_well_state.py, where they can be tested together. +Try to add new tests to test_well_state.py, where they can be tested together, +treating WellState as a private implementation detail. """ from datetime import datetime from opentrons.protocol_engine.types import (