-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Upgrade pydantic to v2 #13983
Comments
Yeah, we definitely want to upgrade Pydantic. (Internal reference: RSS-227) Unfortunately we haven't started that work yet, so there's no branch you could use. We don't have a timeline for it, since we're focusing on the new Opentrons Flex.
This is helpful. Thank you! |
Hello @SyntaxColoring is there any proposed plan for this? |
Sorry for the lack of updates here. Yes, we're working on this in PR #14871. It's not our first priority, though, so I can't promise it will be completed soon. |
Hello @SyntaxColoring, any updates on this? |
Latest update: #14871 (comment) |
please please please prioritize this. Pydantic should have fixed many import perf issues. It's a major pain that we can't easily interoperate between core models in parts of our codebase. |
Overview
Hi team,
Do you have any plans to upgrade pydantic to v2 from v1.8.2? Is there maybe any branch that I could use if such transition is happening? It becomes a problem when you want to use opentrons library in a project where packages dependencies requires pydantic v2. I couldn't find any issue that address that.
Thanks!
Implementation details
I haven't tested that, but this could be a simple fix by using v1 apis from within v2 version, see below:
from pydantic.v1 import BaseModel
There is also a helper package
bump-pydantic
which may help with that. Here is also a migration guide.Design
No response
Acceptance criteria
Lift the dependency from pydantic 1.8.2 to pydantic >=2.
The text was updated successfully, but these errors were encountered: