Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shared-data, labware-library): Add eppendorf labware definitions #16241

Open
wants to merge 7 commits into
base: edge
Choose a base branch
from

Conversation

syao1226
Copy link
Collaborator

@syao1226 syao1226 commented Sep 12, 2024

AUTH-697 and AUTH-698

Overview

Adding new Eppendorf labware definitions with correct module parameters and stacking offsets to shared data and Labware Library.

All new labware details can be found in this spreadsheet.

Test Plan and Hands on Testing

New Labware Testing : This spreadsheet shows all the tests I completed on each of the Eppendorf labware definitions and other new labware definitions. It also includes the LPC offset data for each new labware when placed on a Temperature Module, Magnetic Block, Heater Shaker, and/or Thermocycler Module.

Testing on Flex:

  • Measure stacking offset on selected module adapters using calipers and compare it with definitions.
  • Run a protocol on a PVT robot with a PVT pipette to test the labware on compatible modules by going to the 4 corner wells.
  • Run the Labware Position Check to test the labware dimensions (accepting up to +/- 0.5mm in both the x and y directions due to spring force on the deck slot).
  • Test if the gripper can pick up the labware from any compatible module and place it in any slot without dropping or crashing.

Labware Library:

  • Ensure that the new Eppendorf labware appears under the Well Plate section and that their labware images are displayed correctly.
  1. Eppendorf twin.tec 96 Well Plate 150 µL
  2. Eppendorf 96 Deepwell Plate 1000 µL
  3. Eppendorf 96 Deepwell Plate 2000 µL
  4. Eppendorf twin.tec 384 Well Plate 45 µL

Changelog

  • Added Eppendorf JSON definitions to shared data
  • Updated definitions with module parameters and stacking offsets
  • Added Eppendorf labwares and their images to Labware Library and Labware section in Opentrons app
  • Added Eppendorf labwares to the lists in QuickTransferFlow/constants.ts file: SINGLE_CHANNEL_COMPATIBLE_LABWARE, EIGHT_CHANNEL_COMPATIBLE_LABWARE, and NINETY_SIX_CHANNEL_COMPATIBLE_LABWARE

Review requests

Risk assessment

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.71%. Comparing base (29a2357) to head (35a8b26).
Report is 29 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #16241   +/-   ##
=======================================
  Coverage   73.71%   73.71%           
=======================================
  Files          41       41           
  Lines        2994     2994           
=======================================
  Hits         2207     2207           
  Misses        787      787           
Flag Coverage Δ
shared-data 73.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@syao1226 syao1226 marked this pull request as ready for review September 13, 2024 14:48
@syao1226 syao1226 requested review from a team as code owners September 13, 2024 14:48
Copy link
Member

@sanni-t sanni-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few dimensions are slightly off from the drawings. Were they changed after measuring manually?

"shape": "circular",
"diameter": 7,
"x": 14.4,
"y": 11.3,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The excel sheet mentions this as 11.2mm. Was the 11.3 found out after testing?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why but it was generated by the Custom Labware Creater after I putted 11.2mm as the Y Offset.

},
"wells": {
"A1": {
"depth": 41.1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The depth calculation in the mechanical drawing is a bit confusing one calculation says 41.1mm while other is 40.9. Was this the labware that was making the tip crash a bit when moving to the bottom?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it was the Eppendorf twin.tec 384 Well Plate 45 µL labware that had a tip crash when tested on the DVT Authorship robot.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the well depth is 41.1 mm giving h1 is 38.7 mm and h2 is 2.4 mm.

"diameter": 7,
"x": 14.4,
"y": 74.3,
"z": 3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the depth changes, this will change to 3.2

"xDimension": 8.2,
"yDimension": 8.2,
"x": 14.4,
"y": 11.3,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 11.2mm in the drawing.

"shape": "circular",
"diameter": 3.1,
"x": 12.13,
"y": 8.98,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 8.99mm from drawings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants