Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add new speed for emulsifying pipette plunger #16917

Merged
merged 7 commits into from
Nov 21, 2024

Conversation

caila-marashaj
Copy link
Contributor

@caila-marashaj caila-marashaj commented Nov 20, 2024

Overview

Add a higher speed configuration for the peek pipettes, which will want to move the pipette axis at a max speed of 90, rather than the normal 70 mm/sec.

Changelog

  • add a new highSpeed quirk, and handling for it in the Pipette class
  • change the uiMaxFlowRate in shared data to reflect the new max speed
  • when we attach a pipette, check if it has a highSpeed quirk
  • if so, update the motion constraints to reset only the plunger axis' max speed to 90 mm/s
  • specify the new speed in defaults_ot3
  • add backend functions to change the motion constraints
  • couple tests

@caila-marashaj caila-marashaj requested a review from a team as a code owner November 20, 2024 20:27
@caila-marashaj caila-marashaj force-pushed the EXEC-862-enable-high-speed-peek-pipette branch 3 times, most recently from d5bd5b2 to 061cf6c Compare November 20, 2024 23:21
@ryanthecoder
Copy link
Contributor

Can we add a test to make sure it works in motion planning? and can we update the shared data def to increase the "uiMaxFlowRate", you may need to do some math to figure out what that is now or ask one of the hardware people

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not do logic on display names; those are for human consumption only, and we want the ability to change them for branding reasons or whatever without constraint. Instead, we should use the pipette name (this is "p1000 8 channel" as opposed to "p1000 8 channel v3.3") or something like that. We can add more data or logic if we need to support this, but display names should never show up in logic.

@caila-marashaj caila-marashaj force-pushed the EXEC-862-enable-high-speed-peek-pipette branch from 061cf6c to 0db8365 Compare November 21, 2024 17:31
@caila-marashaj caila-marashaj requested a review from a team as a code owner November 21, 2024 19:39
@caila-marashaj caila-marashaj force-pushed the EXEC-862-enable-high-speed-peek-pipette branch 2 times, most recently from cd37ad7 to ed6d21b Compare November 21, 2024 20:45
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this needs to get merged right now, let's merge it and then immediately start work on removing that if not self.is_simulator thing - there's no reason we should have to have that.

api/src/opentrons/hardware_control/ot3api.py Outdated Show resolved Hide resolved
@caila-marashaj caila-marashaj force-pushed the EXEC-862-enable-high-speed-peek-pipette branch from f845e6d to caed926 Compare November 21, 2024 21:47
@caila-marashaj caila-marashaj merged commit a166bc3 into edge Nov 21, 2024
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants