-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): add new speed for emulsifying pipette plunger #16917
Conversation
d5bd5b2
to
061cf6c
Compare
Can we add a test to make sure it works in motion planning? and can we update the shared data def to increase the "uiMaxFlowRate", you may need to do some math to figure out what that is now or ask one of the hardware people |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not do logic on display names; those are for human consumption only, and we want the ability to change them for branding reasons or whatever without constraint. Instead, we should use the pipette name (this is "p1000 8 channel" as opposed to "p1000 8 channel v3.3") or something like that. We can add more data or logic if we need to support this, but display names should never show up in logic.
061cf6c
to
0db8365
Compare
cd37ad7
to
ed6d21b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this needs to get merged right now, let's merge it and then immediately start work on removing that if not self.is_simulator
thing - there's no reason we should have to have that.
f845e6d
to
caed926
Compare
Overview
Add a higher speed configuration for the peek pipettes, which will want to move the pipette axis at a max speed of 90, rather than the normal 70 mm/sec.
Changelog
highSpeed
quirk, and handling for it in thePipette
classuiMaxFlowRate
in shared data to reflect the new max speedhighSpeed
quirkdefaults_ot3