Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix creating routes for sourced subnets #51

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

acelebanski
Copy link
Contributor

Description

This PR fixes an unique_route_table_ids output in subnet_set module, which took the value directly from route table resource block. Meanwhile, the route table can also be sourced using a data source block. Now the output takes value from a local which takes value from a resource block or data source block depending on a create type variable.

Motivation and Context

Routes for the subnets that were sourced in the code (using data source blocks) were not created in their respective route tables. Basically the vpc_route module failed to fetch the Route Table IDs from subnet_set module when the subnets were sourced.

How Has This Been Tested?

This has been tested locally from my workstation, with a local copy of the module.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@acelebanski acelebanski requested a review from a team as a code owner June 25, 2024 09:39
@sebastianczech
Copy link
Contributor

Nice improvements, it will help a lot, when customer has already VPCs with subnets, thanks 👍

@acelebanski acelebanski merged commit d68831e into main Jun 27, 2024
72 checks passed
@acelebanski acelebanski deleted the unique-rt-ids-output-fix branch June 27, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants